Page MenuHomePhabricator
Differential D9946

Update to @commapp/olm@0.1.0
ClosedPublic
Actions

Authored by ashoat on Nov 21 2023, 11:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 9:31 PM
Unknown Object (File)
Tue, Oct 15, 12:48 AM
Unknown Object (File)
Tue, Oct 15, 12:48 AM
Unknown Object (File)
Tue, Oct 15, 12:48 AM
Unknown Object (File)
Tue, Oct 15, 12:47 AM
Unknown Object (File)
Oct 5 2024, 8:54 PM
Unknown Object (File)
Oct 5 2024, 8:03 PM
Unknown Object (File)
Oct 4 2024, 12:13 PM
View All 56 Files
Subscribers
anunay
tomek

Details

Reviewers
marcin
anunay
atul
Commits
rCOMM4dea57fd9c7a: Update to @commapp/olm@0.1.0
Summary

There have been two commits since the last release:

  1. 6d0eaa993257225faf62768c898fe090fcc2dd2d, which only updates tests
  2. c52b19235729c624690ba1c909c2b31c4314e06d, which updates the session_id function, which we don't currently use in the codebase, and is not internally used in Olm.
Test Plan

Unit tests, CI, and @anunay's test suite

Diff Detail

Repository
rCOMM Comm
Branch
olm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Nov 21 2023, 11:01 AM
Herald added a subscriber: tomek. · View Herald TranscriptNov 21 2023, 11:01 AM
ashoat added inline comments.Nov 21 2023, 11:03 AM
yarn.lock
20944

This line was inserted by GitHub's dependabot.

It happens due to a bug in Yarn... basically if you do a yarn add in a workspace, this line gets added because Yarn isn't paying attention to the resolutions in the root package.json.

The line gets removed if you run a yarn install (or similar) in the workspace root.

Harbormaster completed remote builds in B24313: Diff 33468.Nov 21 2023, 12:07 PM
ashoat requested review of this revision.Nov 21 2023, 12:07 PM
atul accepted this revision.Nov 21 2023, 12:35 PM
This revision is now accepted and ready to land.Nov 21 2023, 12:35 PM
Closed by commit rCOMM4dea57fd9c7a: Update to @commapp/olm@0.1.0 (authored by ashoat). · Explain WhyNov 21 2023, 12:47 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4dea57fd9c7a: Update to @commapp/olm@0.1.0.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines
native/
2 lines
web/
2 lines
13 lines

Diff 33468

View Options

keyserver/package.json

Loading...
View Options

native/package.json

Loading...
View Options

web/package.json

Loading...
View Options

yarn.lock

Loading...