Paths

Table of Contentst

[lib] Remove unnecessary code
ClosedPublic
Actions

Authored by inka on Dec 11 2023, 2:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 9:56 PM

	Unknown Object (File)
	Thu, Nov 7, 11:19 PM

	Unknown Object (File)
	Thu, Nov 7, 11:19 PM

	Unknown Object (File)
	Thu, Nov 7, 11:19 PM

	Unknown Object (File)
	Thu, Nov 7, 11:19 PM

	Unknown Object (File)
	Oct 17 2024, 3:44 AM

	Unknown Object (File)
	Oct 6 2024, 12:26 PM

	Unknown Object (File)
	Oct 5 2024, 3:02 AM

View All 48 Files

Subscribers

ashoat

tomek

Details

Reviewers

michal

Commits

rCOMMe49e478c7697: [lib] Remove unnecessary code

Summary

Since D9500 sessionChange is obligatory in AuthErrorServerSocketMessage. This was dead code.

Test Plan

flow. I checked all places where AUTH_ERROR is returned by the keyserver. They do indeed all specify sessionChange.

Diff Detail

Repository

rCOMM Comm

Branch

inka/remove_some_logout_cases

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Dec 11 2023, 2:56 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 11 2023, 2:56 AM

inka mentioned this in D10287: [lib] Add connectionIssue field.Dec 11 2023, 2:57 AM

Harbormaster completed remote builds in B24936: Diff 34470.Dec 11 2023, 3:16 AM

inka requested review of this revision.Dec 11 2023, 3:16 AM

michal accepted this revision.Dec 11 2023, 3:31 AM

This revision is now accepted and ready to land.Dec 11 2023, 3:31 AM

Closed by commit rCOMMe49e478c7697: [lib] Remove unnecessary code (authored by inka). · Explain WhyDec 11 2023, 5:27 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe49e478c7697: [lib] Remove unnecessary code.

Revision Contents
Changeset List

Path

Size

lib/

socket/

socket.react.js

7 lines

Diff 34470

View Options

lib/socket/socket.react.js

[lib] Remove unnecessary codeClosedPublicActions