[grpc_clients] add connect_timeout to shared grpc client
ClosedPublic
Actions

Authored by varun on Dec 13 2023, 6:54 PM.

Details

Reviewers

ashoat
bartek

Commits

rCOMMd4f399fb614e: [grpc_clients] add connect_timeout to shared grpc client

Summary

by default, the shared grpc client will try to connect indefinitely to the endpoint url. we should time out after 1 second if we're unable to connect.

Test Plan

repro'd ENG-6052 and then added the time out and confirmed that the client only waited 1 second before giving up

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Dec 13 2023, 6:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 13 2023, 6:54 PM

this fixed the same indefinite connection attempt i saw on native too

Harbormaster completed remote builds in B25057: Diff 34617.Dec 13 2023, 7:13 PM

varun requested review of this revision.Dec 13 2023, 7:13 PM

bartek requested changes to this revision.Dec 14 2023, 12:03 AM

bartek added inline comments.

shared/grpc_clients/src/lib.rs
21 ↗	(On Diff #34617)	Isn't this timeout way too short? Maybe for localhost testing it's enough, but real networking isn't that stable. Let's give it at least 5 seconds or so (which is still short IMO)