by default, the shared grpc client will try to connect indefinitely to the endpoint url. we should time out after 1 second if we're unable to connect.
Details
Details
repro'd ENG-6052 and then added the time out and confirmed that the client only waited 1 second before giving up
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
shared/grpc_clients/src/lib.rs | ||
---|---|---|
21 ↗ | (On Diff #34617) | Isn't this timeout way too short? Maybe for localhost testing it's enough, but real networking isn't that stable. |
Comment Actions
increase timeout duration
shared/grpc_clients/src/lib.rs | ||
---|---|---|
21 ↗ | (On Diff #34617) | 1 second was enough for staging, too, but i think it's fine to bump it to 5 |