Page MenuHomePhabricator

[lib] Fix unable to register new user
ClosedPublic

Authored by inka on Dec 28 2023, 8:35 AM.
Tags
None
Referenced Files
F3541606: D10479.id35053.diff
Thu, Dec 26, 6:51 AM
F3541454: D10479.id35082.diff
Thu, Dec 26, 6:30 AM
F3540638: D10479.id35049.diff
Thu, Dec 26, 5:35 AM
Unknown Object (File)
Wed, Dec 25, 5:34 PM
Unknown Object (File)
Nov 16 2024, 7:44 PM
Unknown Object (File)
Nov 16 2024, 7:44 PM
Unknown Object (File)
Nov 16 2024, 7:44 PM
Unknown Object (File)
Nov 16 2024, 7:44 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-6309/unable-to-connect-to-ashoats-keyserver-during-new-registration-flow
This is a super quick fix because this issue is blocking other devs.
The problem was that it was not possible to register a new user, even with Ashoat's keyserver picked

The reason for this happening is that when we are connecting to a new keyserver we don't know its id. So to be able to call it with our actions we create paramOverride, which includes keyserverInfos. In those keyserverInfos the key is the urlPrefix, not admins id. This keyserver is later on added to the store by a setNewSessionActionType.
So what happens in the new registration flow is that when a user selects Ashoat's keyserver, a new entry is added to the keyserverStore.keyserverInfos, with its key being defaultURLPrefix. This entry is broken - hence the missing status, which will be fixed by ENG-6097. But we should either way be using the entry for Ashoat's keyserver that is already in our store.

Test Plan

Tested that it is possible to register a user with the new registration flow, provided Ashoat's keyserver is picked

Diff Detail

Repository
rCOMM Comm
Branch
inka/fix_register_to_ashoat
Lint
No Lint Coverage
Unit
No Test Coverage