Differential D10466
[lib] Separate out bindKeyserverCall cache for each useKeyserverCall callsite Authored by ashoat on Dec 27 2023, 6:36 AM. Tags None Referenced Files
Subscribers
Details The previous diff has one shortcoming, which is mentioned there:
This diff resolves that by lifting the bindCallKeyserverEndpointSelector cache to also be on a per-hook level. We can't make the cache global because the individual hook calls can have their params overriden. Depends on D10465 Before this stack, I was able to reproduce ENG-3612 by going to the ThreadSettings screen in native while my local keyserver was down. After this stack, the issue no longer repros. I also compiled a release build of the iOS app to my phone to confirm that there were no regressions in TTI, or the time it takes to open a MessageList and go back to the ChatThreadList.
Diff Detail
Event TimelineComment Actions When I initially introduced this createSelector+ _memoize memoization, we wanted to memoize globally. If we are removing this requirement anyway, we can probably use the approach you suggested on the original diff D9143. That is remove createSelector and just call the _memoized function inside of useMemo. Comment Actions That's fair – I'll make that change. Worth noting that the new createSelector usage I introduce in D10465 is different, however – in that case, we can't simply replace it with a React.useMemo, because we're taking advantage of the "function that caches its last result" functionality of createSelector in useDerivedObject |