Differential D10577
[lib][native] Rename resolveInvalidatedCookie to resolveKeyserverSessionInvalidationUsingNativeCredentials Authored by ashoat on Jan 8 2024, 9:41 AM. Tags None Referenced Files
Subscribers None
Details Similar to the parent diff. As part of ENG-5940, we're going to be reducing our reliance on this function. If the client is usingCommServicesAccessToken, then instead of calling this function we'll just call the Olm auth responder. As such, it's probably a good idea to rename the function to be more clear about what it does. Depends on D10576 Flow
Diff Detail
Event TimelineThis comment was removed by inka. Comment Actions In D9648 I was asked to create a task to update the call to getOlmSessionInitializationData in resolveInvalidatedCookie. I created ENG-5658. It was later merged with ENG-5940 which this diff is a part of. I'm flagging this so that it doesn't get lost, because it is no longer in the task description, and I don't see any diffs addressing it getOlmSessionInitializationData was since moved into getInitialNotificationsEncryptedMessage, but the problem is still the same - we want to move away from using callServerEndpoint and useServerCall directly. Comment Actions Thanks for flagging that @inka. One question for you about this part:
I think we might want to keep the old code around for a while so we can safely roll back the identity launch if there are issues. For some time we'll be gating it on usingCommServicesAccessToken. Do you think we'll need to refactor getOlmSessionInitializationData in the interim then? Comment Actions We discussed this on our 1:1 - this is not a priority, because the current code works, but we want to eventually refactor getOlmSessionInitializationData to use callKeyserverEndpoint. ENG-5658 was reopened to address this. |