Page MenuHomePhabricator
Differential D10935

[native] Fix crash in Crash component due to missing CallKeyserverEndpointContext
ClosedPublic
Actions

Authored by ashoat on Feb 2 2024, 6:33 AM.
Tags
None
Referenced Files
F3296611: D10935.id36588.diff
Sun, Nov 17, 1:53 AM
F3295923: D10935.diff
Sat, Nov 16, 11:53 PM
Unknown Object (File)
Wed, Nov 13, 11:53 PM
Unknown Object (File)
Fri, Nov 1, 9:13 AM
Unknown Object (File)
Fri, Nov 1, 9:13 AM
Unknown Object (File)
Fri, Nov 1, 9:12 AM
Unknown Object (File)
Fri, Nov 1, 9:12 AM
Unknown Object (File)
Oct 1 2024, 3:22 AM
View All 52 Files
Subscribers
tomek

Details

Reviewers
bartek
inka
Commits
rCOMM99adc85216db: [native] Fix crash in Crash component due to missing…
Summary

I missed that the ErrorBoundary calls keyserver logout, which requires CallKeyserverEndpointProvider to be above it in the React component hierarchy.

This solves ENG-6665.

Test Plan

I triggered a crash through the dev menu and confirmed it worked like before (outside of an unrelated issue, documented here

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 2 2024, 6:33 AM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 2 2024, 6:33 AM
ashoat published this revision for review.Feb 2 2024, 6:34 AM
bartek accepted this revision.Feb 2 2024, 6:37 AM

Thank You!

This revision is now accepted and ready to land.Feb 2 2024, 6:37 AM
This revision was landed with ongoing or failed builds.Feb 2 2024, 6:56 AM
Closed by commit rCOMM99adc85216db: [native] Fix crash in Crash component due to missing… (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM99adc85216db: [native] Fix crash in Crash component due to missing….
Harbormaster completed remote builds in B26468: Diff 36588.Feb 2 2024, 7:15 AM

Revision Contents
Changeset List

PathSize
native/
134 lines

Diff 36588

View Options

native/root.react.js

Loading...