Page MenuHomePhabricator
Differential D11011

[lib] Update genesis.id to use authoritativeKeyserverID
ClosedPublic
Actions

Authored by inka on Feb 9 2024, 7:52 AM.
Tags
None
Referenced Files
F3538692: D11011.id37351.diff
Wed, Dec 25, 11:43 PM
F3538419: D11011.id37507.diff
Wed, Dec 25, 10:53 PM
F3537593: D11011.id37004.diff
Wed, Dec 25, 10:02 PM
Unknown Object (File)
Tue, Dec 24, 5:06 AM
Unknown Object (File)
Tue, Dec 24, 5:06 AM
Unknown Object (File)
Tue, Dec 24, 5:06 AM
Unknown Object (File)
Tue, Dec 24, 5:06 AM
Unknown Object (File)
Tue, Dec 24, 5:06 AM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMMd303d990d9ba: [lib] Update genesis.id to use authoritativeKeyserverID
Summary

issue: https://linear.app/comm/issue/ENG-6727/use-authoritativekeyserverid-in-genesis
GENESIS is the community holding DMs and thick threads for now. We want to have one GENESIS in our setups, hosted by the authoritative keyserver

Test Plan

Tested on web and native that it is possible to create a thick thread, and no errors show up.
Checked on web that the created chat has parentThreadID: "256|1", where 256 is the value of authoritativeKeyserverID in my setup.
That checks that gnesis.id is set properly, because of code in lib/actions/thread-actions.js newTread action, which if not provided a parentThreadID uses genesis.id (I made sure that was the case)

Diff Detail

Repository
rCOMM Comm
Branch
inka/testing_multikeyservers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 9 2024, 7:52 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 9 2024, 7:52 AM
inka added a parent revision: D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.Feb 9 2024, 7:52 AM
Harbormaster completed remote builds in B26711: Diff 36934.Feb 9 2024, 8:07 AM
inka requested review of this revision.Feb 9 2024, 8:07 AM
tomek accepted this revision.Feb 12 2024, 1:19 AM
tomek added inline comments.
lib/facts/genesis.js
13
This revision is now accepted and ready to land.Feb 12 2024, 1:19 AM
inka updated this revision to Diff 37004.Feb 12 2024, 8:02 AM

Address review

Harbormaster completed remote builds in B26765: Diff 37004.Feb 12 2024, 8:20 AM
inka added a child revision: D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().Feb 13 2024, 3:39 AM
inka updated this revision to Diff 37351.Feb 20 2024, 4:40 AM

Turn genesis into a funtion - in lib we cannot call authoritativeKeyserverID top level, because configs are not registered yet

inka requested review of this revision.Feb 20 2024, 4:40 AM
Harbormaster completed remote builds in B26991: Diff 37351.Feb 20 2024, 4:59 AM
tomek accepted this revision.Feb 21 2024, 1:37 AM
tomek added inline comments.
keyserver/src/database/migration-config.js
605–607 ↗(On Diff #37351)

Why was the formatting changed?

This revision is now accepted and ready to land.Feb 21 2024, 1:37 AM
inka added inline comments.Feb 21 2024, 3:42 AM
keyserver/src/database/migration-config.js
605–607 ↗(On Diff #37351)

This code was over 80 characters

Closed by commit rCOMMd303d990d9ba: [lib] Update genesis.id to use authoritativeKeyserverID (authored by inka). · Explain WhyFeb 23 2024, 4:35 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMd303d990d9ba: [lib] Update genesis.id to use authoritativeKeyserverID.

Revision Contents
Changeset List

PathSize
lib/
facts/
4 lines

Diff 36934

View Options

lib/facts/genesis.js

Loading...