Page MenuHomePhabricator

[lib] Introduce `patchRoleInfoWithSpecialRole(RoleInfo): RoleInfo`
ClosedPublic

Authored by atul on Feb 13 2024, 12:22 PM.
Tags
None
Referenced Files
F3385492: D11055.diff
Fri, Nov 29, 12:38 AM
Unknown Object (File)
Oct 25 2024, 6:01 PM
Unknown Object (File)
Oct 20 2024, 7:58 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Aug 29 2024, 11:10 AM
Subscribers

Details

Summary

This utility function will be consumed by native and web migration to set the specialRole field for existing threads in the thread store.

Created separate diffs and unit tests for this function so I could test in lightweight way before testing migration which is more heavy weight

Test Plan

Unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/shared/thread-utils.js
1086–1091 ↗(On Diff #37039)

Previously this got introduced in D10116

atul published this revision for review.Feb 13 2024, 12:37 PM
atul retitled this revision from [lib] Introduce `patchRoleInfoWithSpecialRole` to [lib] Introduce `patchRoleInfoWithSpecialRole(RoleInfo): RoleInfo`.
This revision is now accepted and ready to land.Feb 13 2024, 12:55 PM