Details
- Reviewers
tomek michal - Commits
- rCOMM0a0ba7aa6f7c: [keyserver] Replace ashoat with admin
Tested that creating a new db is successful - a user with the id provided by identity service is created and added to the users table(with the correct name), GENESIS is correctly created with creator id set to this id, user_id field is correctly filled
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/testing_multikeyservers
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/database/setup-db.js | ||
|---|---|---|
| 25–27 ↗ | (On Diff #37322) | Is it OK to call createOlmAccounts before users in the DB exist? |
| 433–453 ↗ | (On Diff #37322) | Can we keep inserting admin.id in the same statement where it was? It should be possible by e.g. conditionally appending a query, or creating a values array and pushing to it based on a condition. If it appears challenging, we should at least fix the formatting - when we insert a single value, it is placed in the same line as VALUES keyword. |
| keyserver/src/scripts/create-community.js | ||
| 14 ↗ | (On Diff #37322) | |
| keyserver/src/user/identity.js | ||
| 55–56 ↗ | (On Diff #37322) | |
| 75 ↗ | (On Diff #37322) | |
Address review. I tested that the query still executes correctly for both uuid and a number like id
| keyserver/src/database/setup-db.js | ||
|---|---|---|
| 25–27 ↗ | (On Diff #37322) | Yes, createOlmAccounts doesn't fetch anything from the db. It calls createPickledOlmAccount which basically only uses olm from '@commapp/olm', and uuid from uuid'. then it stores the data in olm_accounts table. Nothing else is being done. |