Differential D11145

[keyserver] improve error message on identity connection failure
ClosedPublic
Actions

Authored by varun on Feb 22 2024, 8:43 AM.

Details

Reviewers

will

Commits

rCOMM204ce2737677: [keyserver] improve error message on identity connection failure

Summary

the existing error message, "Unable to connect to identity service," is not very helpful

Test Plan

tried to connect to my local identity service which was not running. Saw this error in the keyserver logs:

[NODEM] Failed to register user: Transport Error: tonic::transport::Error(Transport, hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })))

much better than just "Unable to connect to identity service"

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Feb 22 2024, 8:43 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 22 2024, 8:43 AM

keep original error message too

Harbormaster completed remote builds in B27070: Diff 37448.Feb 22 2024, 8:58 AM

Harbormaster completed remote builds in B27072: Diff 37450.Feb 22 2024, 9:10 AM

varun requested review of this revision.Feb 22 2024, 9:10 AM

will accepted this revision.Feb 22 2024, 10:34 AM

This revision is now accepted and ready to land.Feb 22 2024, 10:34 AM

Closed by commit rCOMM204ce2737677: [keyserver] improve error message on identity connection failure (authored by varun). · Explain WhyFeb 22 2024, 11:12 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM204ce2737677: [keyserver] improve error message on identity connection failure.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

mod.rs

14 lines

Diff 37448

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

[keyserver] improve error message on identity connection failureClosedPublicActions