Page MenuHomePhabricator
Differential D11146

[lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat
ClosedPublic
Actions

Authored by inka on Feb 22 2024, 8:49 AM.
Tags
None
Referenced Files
F3526897: D11146.id37514.diff
Tue, Dec 24, 2:04 AM
F3526896: D11146.id37502.diff
Tue, Dec 24, 2:04 AM
F3526895: D11146.id37449.diff
Tue, Dec 24, 2:04 AM
F3526881: D11146.id.diff
Tue, Dec 24, 2:04 AM
F3526872: D11146.diff
Tue, Dec 24, 2:04 AM
Unknown Object (File)
Wed, Dec 4, 9:48 PM
Unknown Object (File)
Thu, Nov 28, 3:08 PM
Unknown Object (File)
Tue, Nov 26, 4:00 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM5a38af1e5a29: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat
Summary

issue: https://linear.app/comm/issue/ENG-6907/update-getdefaultavatar-and-threadmemberswithoutaddedashoat
getDefaultAvatar should strip any keyserver prefix
threadMembersWithoutAddedAshoat should remove any admin

Test Plan

tested that threadMembersWithoutAddedAshoat correctly removes admin
tested that getDefaultAvatar correctly splits the string

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 22 2024, 8:49 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 22 2024, 8:49 AM
inka added a parent revision: D11140: [lib] reduce currentUserInfo on identity login/register.Feb 22 2024, 8:50 AM
inka added a child revision: D11141: [IGNORE] Client hacks for testing multiple keyservers.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2024, 8:57 AM
Harbormaster failed remote builds in B27071: Diff 37449!
Harbormaster completed remote builds in B27071: Diff 37449.Feb 22 2024, 11:36 PM
inka requested review of this revision.Feb 22 2024, 11:36 PM
michal added inline comments.Feb 23 2024, 3:28 AM
lib/shared/thread-utils.js
241 ↗(On Diff #37449)

Should the function be renamed?

tomek accepted this revision.Feb 23 2024, 3:50 AM
This revision is now accepted and ready to land.Feb 23 2024, 3:50 AM
inka updated this revision to Diff 37502.Feb 23 2024, 4:09 AM

Rename

Harbormaster completed remote builds in B27106: Diff 37502.Feb 23 2024, 4:23 AM
Closed by commit rCOMM5a38af1e5a29: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat (authored by inka). · Explain WhyFeb 23 2024, 4:35 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5a38af1e5a29: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.

Revision Contents
Changeset List

PathSize
lib/
shared/
7 lines
13 lines

Diff 37502

View Options

lib/shared/avatar-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...