[nix] Run set-up-authoritative-keyserver.sh on nix startup
ClosedPublic
Actions

Authored by inka on Mar 12 2024, 7:13 AM.

Details

Reviewers

michal
tomek

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMda499ccaf125: [nix] Run set-up-authoritative-keyserver.sh on nix startup

Summary

issue: ENG-6845
We want to run set-up-authoritative-keyserver.sh when nix is run.

Test Plan

Ran nix develop and checked that the script is executed

Diff Detail

Repository

rCOMM Comm

Branch

inka/march

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Mar 12 2024, 7:13 AM

Owners added a reviewer: Restricted Owners Package.Mar 12 2024, 7:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 12 2024, 7:13 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 12 2024, 8:19 AM

Harbormaster failed remote builds in B27473: Diff 38022!

inka requested review of this revision.Mar 12 2024, 8:57 AM

emscripten hangs because it waits for user input

Add timeout

inka added a parent revision: D11282: [keyserver] Create json files with authoritative keyserver id.Mar 12 2024, 9:16 AM

Harbormaster completed remote builds in B27476: Diff 38025.Mar 12 2024, 9:24 AM

michal requested changes to this revision.Mar 12 2024, 9:42 AM

michal added inline comments.

scripts/set-up-authoritative-keyserver.sh
8 ↗	(On Diff #38025)	Instead of a timeout it would be better to skip this script on CI: Buildkite: # from keyserver/addons/rust-node-addon/install_ci_deps.sh if [[ -z "$BUILDKITE" ]]; then exit fi Github: there is a similar env variable: `GITHUB_ACTIONS` (docs)

This revision now requires changes to proceed.Mar 12 2024, 9:42 AM

If running inside buildkite or github actions - exit.
I tested that if both are empty, the sqript continues, and if one of them or both are not empty, the script exits

Harbormaster completed remote builds in B27480: Diff 38029.Mar 12 2024, 10:20 AM

michal accepted this revision.Mar 13 2024, 3:50 AM

This revision is now accepted and ready to land.Mar 13 2024, 3:50 AM

Closed by commit rCOMMda499ccaf125: [nix] Run set-up-authoritative-keyserver.sh on nix startup (authored by inka). · Explain WhyMar 13 2024, 3:57 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMda499ccaf125: [nix] Run set-up-authoritative-keyserver.sh on nix startup.