Page MenuHomePhabricator
Differential D11314

[olm] implement tests to new error messages & message order
ClosedPublic
Actions

Authored by kamil on Mar 13 2024, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:52 PM
Unknown Object (File)
Fri, Nov 8, 1:39 PM
Unknown Object (File)
Fri, Nov 8, 7:15 AM
Unknown Object (File)
Fri, Nov 8, 7:15 AM
Unknown Object (File)
Fri, Nov 8, 7:15 AM
Unknown Object (File)
Fri, Nov 8, 7:15 AM
Unknown Object (File)
Fri, Nov 8, 1:01 AM
Unknown Object (File)
Thu, Nov 7, 9:40 PM
View All 68 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM48e292e554bb: [olm] implement tests to new error messages & message order
Summary

Tests for https://github.com/CommE2E/olm/pull/12 and https://github.com/CommE2E/olm/pull/11.

After PRs are merged and the olm release is made I'll update the package.json file to the propper version and publish this diff for review.

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
bump-olm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mar 13 2024, 9:48 AM
kamil held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptMar 13 2024, 9:48 AM
Harbormaster failed remote builds in B27484: Diff 38041!Mar 13 2024, 9:49 AM
kamil edited the summary of this revision. (Show Details)Mar 13 2024, 10:04 AM
kamil edited the test plan for this revision. (Show Details)
kamil updated this revision to Diff 38095.Mar 15 2024, 5:29 AM

bump version

kamil added a parent revision: D11337: [olm] bump `@commapp/olm` version.Mar 15 2024, 5:30 AM
Harbormaster failed remote builds in B27527: Diff 38095!Mar 15 2024, 5:45 AM
kamil updated this revision to Diff 38102.Mar 15 2024, 6:59 AM

add type

kamil added inline comments.Mar 15 2024, 7:07 AM
keyserver/flow-typed/npm/@commapp/olm_vx.x.x.js
80 ↗(On Diff #38102)

Looks like I missed adding this to TS types in olm repo - @ashoat do you think I should open another PR to add this?

Harbormaster completed remote builds in B27533: Diff 38102.Mar 15 2024, 7:15 AM
kamil published this revision for review.Mar 15 2024, 7:21 AM
ashoat accepted this revision.Mar 15 2024, 10:31 AM
ashoat added inline comments.
keyserver/flow-typed/npm/@commapp/olm_vx.x.x.js
80 ↗(On Diff #38102)

Up to you... I'm not sure it matters very much given we don't use TS

keyserver/src/utils/olm-utils.test.js
262–263 ↗(On Diff #38102)

It's not clear to me why this line is needed

This revision is now accepted and ready to land.Mar 15 2024, 10:31 AM
kamil added inline comments.Mar 18 2024, 1:46 AM
keyserver/src/utils/olm-utils.test.js
262–263 ↗(On Diff #38102)

I wanted to use the same convention as with the test above. (this function can return false on create_inbound failure)

Closed by commit rCOMM48e292e554bb: [olm] implement tests to new error messages & message order (authored by kamil). · Explain WhyMar 18 2024, 1:50 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM48e292e554bb: [olm] implement tests to new error messages & message order.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
86 lines

Diff 38095

View Options

keyserver/src/utils/olm-utils.test.js

Loading...