Page MenuHomePhabricator
Differential D11328

Implement multiple keyserver unread count on web and desktop on top of IndexedDB
ClosedPublic
Actions

Authored by marcin on Mar 14 2024, 6:34 AM.
Tags
None
Referenced Files
F3489790: D11328.diff
Wed, Dec 18, 1:40 PM
Unknown Object (File)
Thu, Dec 5, 12:08 AM
Unknown Object (File)
Wed, Nov 20, 5:44 PM
Unknown Object (File)
Nov 16 2024, 5:49 AM
Unknown Object (File)
Nov 16 2024, 2:12 AM
Unknown Object (File)
Nov 6 2024, 3:35 PM
Unknown Object (File)
Oct 24 2024, 6:45 AM
Unknown Object (File)
Oct 24 2024, 1:43 AM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
Commits
rCOMMb38561ab2233: Implement multiple keyserver unread count on web and desktop on top of IndexedDB
Summary

This differential implements unread count handling from multiple keyservers

Test Plan
  1. Ensure that unread count is working properly.
  2. Toggle developer tools and ensure that there is relevant entry in IndexDB the corresponds to unread count for the keyserver that we logged in to.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-6853
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Mar 14 2024, 6:34 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 14 2024, 6:34 AM
marcin added a parent revision: D11304: Refactor notifications sessions storage to support multiple keyservers on web and desktop.Mar 14 2024, 6:36 AM
Harbormaster completed remote builds in B27506: Diff 38063.Mar 14 2024, 6:49 AM
marcin requested review of this revision.Mar 14 2024, 6:49 AM
marcin updated this revision to Diff 38098.Mar 15 2024, 6:24 AM
  1. Fix potential issues related to desktop-web code version discrepancy.
Harbormaster failed remote builds in B27530: Diff 38098!Mar 15 2024, 6:37 AM
marcin updated this revision to Diff 38101.Mar 15 2024, 6:59 AM

Fix eslint by adding hook dependency

Harbormaster completed remote builds in B27532: Diff 38101.Mar 15 2024, 7:14 AM
michal accepted this revision.Mar 18 2024, 7:00 AM
michal added inline comments.
web/push-notif/notif-crypto-utils.js
520–531 ↗(On Diff #38101)

I don't like depending on ordering and indexes so alternatively we could do something like this. But both are fine.

This revision is now accepted and ready to land.Mar 18 2024, 7:00 AM
marcin updated this revision to Diff 38224.Mar 20 2024, 4:21 AM
  1. Update queryNotifsUnreadCountStorage function not to rely on array ordering.
  2. Rebase before landing
Harbormaster completed remote builds in B27626: Diff 38224.Mar 20 2024, 4:35 AM
Closed by commit rCOMMb38561ab2233: Implement multiple keyserver unread count on web and desktop on top of IndexedDB (authored by marcin). · Explain WhyMar 20 2024, 5:37 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMb38561ab2233: Implement multiple keyserver unread count on web and desktop on top of IndexedDB.

Revision Contents
Changeset List

PathSize
web/
push-notif/
66 lines
74 lines

Diff 38224

View Options

web/push-notif/badge-handler.react.js

Loading...
View Options

web/push-notif/notif-crypto-utils.js

Loading...