[keyserver] Debounce one-time key refresh request
ClosedPublic
Actions

Authored by ashoat on Mar 24 2024, 7:49 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM9413ba103cad: [keyserver] Debounce one-time key refresh request

Summary

Identity will queue up a request for 5 new one-time keys every time it fails to find one. If a keyserver is offline for a bit, this can lead to a large queue of requests for one-time keys.

Instead of adding 5 new one-time keys for each message, I think we should debounce the requests. This diff makes us process just two requests (one leading and one trailing) if we see a large queue when we start up. From there, each additional message will be processed independently.

This addresses ENG-7383. More details there.

Depends on D11375

Test Plan

I enqueued 10 requests for new one-time keys, and then started the keyserver and observed that only 10 one-time keys were added to DynamoDB (meaning only two of the requests were processed)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 24 2024, 7:49 PM

Harbormaster completed remote builds in B27661: Diff 38283.Mar 24 2024, 8:04 PM

ashoat requested review of this revision.Mar 24 2024, 8:04 PM

This looks reasonable, but I'm wondering if we shouldn't solve this on Identity service: it knows how many keys are there, and how many keys are needed to fulfill requests, and could ask a keyserver for the appropriate number. Also, it should know that a keyserver was asked for the keys recently and can decide either to not ask for more or to ask for e.g. only one more.

This revision is now accepted and ready to land.Mar 25 2024, 6:51 AM

Yes, we could consider skipping Tunnelbroker and having clients connect directly to identity (eg. via WebSocket)

That said it would require changing some architecture and this is a quick fix that works, so going to land for now

Closed by commit rCOMM9413ba103cad: [keyserver] Debounce one-time key refresh request (authored by ashoat). · Explain WhyMar 25 2024, 9:37 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9413ba103cad: [keyserver] Debounce one-time key refresh request.

ashoat mentioned this in D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.Jun 13 2024, 8:28 AM