Part of ENG-7837.
This is different than client DeviceListUpdated because:
- Indicating that this message was sent by Identity.
- In this case we also want the receiving device to re-send this to all other peers.
Differential D12375
[lib] add `IdentityDeviceListUpdated` P2P message type kamil on Jun 10 2024, 4:43 AM. Authored by Tags None Referenced Files
Subscribers
Details
Diff Detail
Event TimelineComment Actions
Some questions:
Comment Actions Yes, if a device receives IdentityDeviceListUpdated, it must broadcast standardized DeviceListUpdated to all its peers because only the receiving device knows the peer list.
The message will be received by all devices left on the device list - we can update this to send this message to only the primary device, I am open to suggestions. For more context see the comment here. Comment Actions
What happens if the devices are offline? Wondering if there will be an issues in the interim period, between when identity has updated the device list, and when the peers will receive the message to update their device lists for that user.
It sounds like each receiving peer device will receive a message from each of the sending user's devices. On the receiving side, do we have a way to debounce these messages? Something like D11376 Comment Actions In the worst-case scenario, other peers will still think that this device is still available and can send messages to it in this time period. But in the future, we'll have to wait for the primary to be online to sign the updates device list so this case is not worse anyway.
We don't have a mechanism to debounce this, as a follow-up I can:
But keep in mind that this is only temporary to ensure peer lists are up to date with legacy Identity auth, in the future, this code should be removed. Sorry for the response after landing. |