Page MenuHomePhabricator
Differential D12373

[lib] factor out broadcasting device list updates to hook
ClosedPublic
Actions

Authored by kamil on Mon, Jun 10, 4:25 AM.
Tags
None
Referenced Files
F2146769: D12373.id.diff
Sun, Jun 30, 12:23 AM
Unknown Object (File)
Sat, Jun 29, 5:16 PM
Unknown Object (File)
Thu, Jun 27, 4:27 AM
Unknown Object (File)
Mon, Jun 24, 11:37 AM
Unknown Object (File)
Sat, Jun 22, 4:41 AM
Unknown Object (File)
Sat, Jun 22, 4:18 AM
Unknown Object (File)
Fri, Jun 21, 7:53 AM
Unknown Object (File)
Thu, Jun 20, 2:45 PM
View All 17 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook
Summary

We want to reuse this code in more places, whenever disseminating device list updates.

Depends on D12347

Test Plan

Hook tested by calling function.
Secondary device auth not tested because of: ENG-8385.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Jun 10, 4:25 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 10, 4:25 AM
kamil added a child revision: D12374: [lib] factor out getting and updating device list to hook.Mon, Jun 10, 4:32 AM
Harbormaster completed remote builds in B29566: Diff 41153.Mon, Jun 10, 4:40 AM
kamil edited the summary of this revision. (Show Details)Mon, Jun 10, 9:41 AM
kamil published this revision for review.Mon, Jun 10, 9:50 AM
tomek accepted this revision.Wed, Jun 12, 5:43 AM
This revision is now accepted and ready to land.Wed, Jun 12, 5:43 AM
bartek added inline comments.Wed, Jun 12, 8:44 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗(On Diff #41153)

We have fetchLatestDeviceList() in lib/shared/device-list-utils.js that does exactly this

kamil added inline comments.Thu, Jun 13, 7:54 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗(On Diff #41153)

yeah but in this case we also need lastSignedDeviceList

Closed by commit rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook (authored by kamil). · Explain WhyThu, Jun 13, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
50 lines
native/
profile/
50 lines

Diff 41298

View Options

lib/hooks/peer-list-hooks.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...