Page MenuHomePhabricator
Differential D12373

[lib] factor out broadcasting device list updates to hook
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Feb 15 2025, 8:27 PM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Jan 24 2025, 9:33 PM
Unknown Object (File)
Jan 24 2025, 9:33 PM
View All 65 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook
Summary

We want to reuse this code in more places, whenever disseminating device list updates.

Depends on D12347

Test Plan

Hook tested by calling function.
Secondary device auth not tested because of: ENG-8385.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 4:25 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:25 AM
kamil added a child revision: D12374: [lib] factor out getting and updating device list to hook.Jun 10 2024, 4:32 AM
Harbormaster completed remote builds in B29566: Diff 41153.Jun 10 2024, 4:40 AM
kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:41 AM
kamil published this revision for review.Jun 10 2024, 9:50 AM
tomek accepted this revision.Jun 12 2024, 5:43 AM
This revision is now accepted and ready to land.Jun 12 2024, 5:43 AM
bartek added inline comments.Jun 12 2024, 8:44 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗(On Diff #41153)

We have fetchLatestDeviceList() in lib/shared/device-list-utils.js that does exactly this

kamil added inline comments.Jun 13 2024, 7:54 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗(On Diff #41153)

yeah but in this case we also need lastSignedDeviceList

Closed by commit rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
50 lines
native/
profile/
50 lines

Diff 41298

View Options

lib/hooks/peer-list-hooks.js

Show All 35 Linespublic struct VideoInfo: Record {
var format: String = "N/A" var format: String = "N/A"
} }
public class MediaModule: Module { public class MediaModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("MediaModule") Name("MediaModule")
AsyncFunction("getVideoInfo", getVideoInfo) AsyncFunction("getVideoInfo", getVideoInfo)
AsyncFunction("hasMultipleFrames", hasMultipleFrames)
} }
// MARK: - Function implementations // MARK: - Function implementations
private func getVideoInfo(path: URL) throws -> VideoInfo { private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path) let asset = AVAsset(url: path)
Show All 15 Lines private func getVideoInfo(path: URL) throws -> VideoInfo {
} else { } else {
throw NoVideoTrackException(path) throw NoVideoTrackException(path)
} }
videoInfo.format = path.pathExtension videoInfo.format = path.pathExtension
return videoInfo return videoInfo
} }
private func hasMultipleFrames(path: URL) throws -> Bool {
guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
throw FailedToLoadGifException(path)
}
let count = CGImageSourceGetCount(imageSource)
return count > 1
}
} }
// MARK: - Exception definitions // MARK: - Exception definitions
private class NoVideoTrackException: GenericException<URL> { private class NoVideoTrackException: GenericException<URL> {
override var reason: String { override var reason: String {
"No video track found in file URI: \(param)" "No video track found in file URI: \(param)"
} }
} }
private class FailedToLoadGifException: GenericException<URL> {
override var reason: String {
"Failed to load gif at URI: \(param)"
}
}
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Show All 35 Linespublic struct VideoInfo: Record {
var format: String = "N/A" var format: String = "N/A"
} }
public class MediaModule: Module { public class MediaModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("MediaModule") Name("MediaModule")
AsyncFunction("getVideoInfo", getVideoInfo) AsyncFunction("getVideoInfo", getVideoInfo)
AsyncFunction("hasMultipleFrames", hasMultipleFrames)
} }
// MARK: - Function implementations // MARK: - Function implementations
private func getVideoInfo(path: URL) throws -> VideoInfo { private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path) let asset = AVAsset(url: path)
Show All 15 Lines private func getVideoInfo(path: URL) throws -> VideoInfo {
} else { } else {
throw NoVideoTrackException(path) throw NoVideoTrackException(path)
} }
videoInfo.format = path.pathExtension videoInfo.format = path.pathExtension
return videoInfo return videoInfo
} }
private func hasMultipleFrames(path: URL) throws -> Bool {
guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
throw FailedToLoadGifException(path)
}
let count = CGImageSourceGetCount(imageSource)
return count > 1
}
} }
// MARK: - Exception definitions // MARK: - Exception definitions
private class NoVideoTrackException: GenericException<URL> { private class NoVideoTrackException: GenericException<URL> {
override var reason: String { override var reason: String {
"No video track found in file URI: \(param)" "No video track found in file URI: \(param)"
} }
} }
private class FailedToLoadGifException: GenericException<URL> {
override var reason: String {
"Failed to load gif at URI: \(param)"
}
}