Details

Reviewers

bartek
tomek

Commits

rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook

Summary

We want to reuse this code in more places, whenever disseminating device list updates.

Depends on D12347

Test Plan

Hook tested by calling function.
Secondary device auth not tested because of: ENG-8385.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 11:25 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 11:25 AM

kamil added a child revision: D12374: [lib] factor out getting and updating device list to hook.Jun 10 2024, 11:32 AM

Harbormaster completed remote builds in B29566: Diff 41153.Jun 10 2024, 11:40 AM

kamil edited the summary of this revision. (Show Details)Jun 10 2024, 4:41 PM

kamil published this revision for review.Jun 10 2024, 4:50 PM

tomek accepted this revision.Jun 12 2024, 12:43 PM

This revision is now accepted and ready to land.Jun 12 2024, 12:43 PM

bartek added inline comments.Jun 12 2024, 3:44 PM

native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗	(On Diff #41153)	We have `fetchLatestDeviceList()` in `lib/shared/device-list-utils.js` that does exactly this

kamil added inline comments.Jun 13 2024, 2:54 PM

native/profile/secondary-device-qr-code-scanner.react.js
107–112 ↗	(On Diff #41153)	yeah but in this case we also need `lastSignedDeviceList`

Closed by commit rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook. · Explain WhyJun 13 2024, 4:08 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook.

[lib] factor out broadcasting device list updates to hook
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41298

lib/hooks/peer-list-hooks.js

native/profile/secondary-device-qr-code-scanner.react.js

[lib] factor out broadcasting device list updates to hookClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41298

lib/hooks/peer-list-hooks.js

native/profile/secondary-device-qr-code-scanner.react.js

[lib] factor out broadcasting device list updates to hook
ClosedPublic
Actions

Revision Contents
Changeset List