Page MenuHomePhabricator
Differential D12383

[lib] refresh device lists after restore
AbandonedPublic
Actions

Authored by kamil on Jun 10 2024, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 7:10 AM
Unknown Object (File)
Sat, Mar 1, 2:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Jan 24 2025, 9:33 PM
Unknown Object (File)
Jan 24 2025, 9:33 PM
Unknown Object (File)
Dec 30 2024, 12:41 AM
Unknown Object (File)
Dec 25 2024, 6:35 PM
Unknown Object (File)
Dec 25 2024, 6:33 PM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

After restoring the backup device can have outdated device lists, the easiest way to fix this is to remove device lists and D12330 will automatically re-fetch data from Identity, and also D12382 will create new olm sessions.

Depends on D12381

Test Plan
  1. Not testing restore/backup
  2. Dispatch action and test if device lists are cleared and refreshed

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 10 2024, 9:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 9:37 AM
kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:49 AM
kamil published this revision for review.Jun 10 2024, 9:53 AM
Harbormaster completed remote builds in B29580: Diff 41171.Jun 10 2024, 9:54 AM
tomek accepted this revision.Jun 13 2024, 3:46 AM
tomek added inline comments.
lib/hooks/qr-auth.js
131–136

This doesn't make too much sense to me. If we want to remove the device lists after restoration, shouldn't we simply not persist them?

We've discussed this with @kamil and it seems like this solution is better than its alternatives.

This revision is now accepted and ready to land.Jun 13 2024, 3:46 AM
kamil abandoned this revision.Jun 13 2024, 9:16 AM

context in ENG-7246

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
hooks/
12 lines
reducers/
17 lines
types/
4 lines

Diff 41171

View Options

lib/actions/aux-user-actions.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

lib/hooks/qr-auth.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

lib/reducers/aux-user-reducer.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines