Page MenuHomePhabricator

[lib] refresh device lists after restore
AbandonedPublic

Authored by kamil on Mon, Jun 10, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 3:31 AM
Unknown Object (File)
Thu, Jun 20, 5:45 AM
Unknown Object (File)
Sat, Jun 15, 12:31 PM
Unknown Object (File)
Sat, Jun 15, 12:05 PM
Unknown Object (File)
Fri, Jun 14, 8:38 PM
Unknown Object (File)
Fri, Jun 14, 7:15 AM
Unknown Object (File)
Mon, Jun 10, 10:38 AM
Unknown Object (File)
Mon, Jun 10, 10:35 AM
Subscribers

Details

Reviewers
bartek
tomek
Summary

After restoring the backup device can have outdated device lists, the easiest way to fix this is to remove device lists and D12330 will automatically re-fetch data from Identity, and also D12382 will create new olm sessions.

Depends on D12381

Test Plan
  1. Not testing restore/backup
  2. Dispatch action and test if device lists are cleared and refreshed

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Mon, Jun 10, 9:53 AM
tomek added inline comments.
lib/hooks/qr-auth.js
131–136

This doesn't make too much sense to me. If we want to remove the device lists after restoration, shouldn't we simply not persist them?

We've discussed this with @kamil and it seems like this solution is better than its alternatives.

This revision is now accepted and ready to land.Thu, Jun 13, 3:46 AM