[lib] refresh device lists after restore
AbandonedPublic
Actions

Authored by kamil on Jun 10 2024, 4:37 PM.

Details

Reviewers

bartek
tomek

Summary

After restoring the backup device can have outdated device lists, the easiest way to fix this is to remove device lists and D12330 will automatically re-fetch data from Identity, and also D12382 will create new olm sessions.

Depends on D12381

Test Plan

Not testing restore/backup
Dispatch action and test if device lists are cleared and refreshed

Diff Detail

Repository

rCOMM Comm

Branch

peer-list-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 10 2024, 4:37 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:37 PM

kamil edited the summary of this revision. (Show Details)Jun 10 2024, 4:49 PM

kamil published this revision for review.Jun 10 2024, 4:53 PM

Harbormaster completed remote builds in B29580: Diff 41171.Jun 10 2024, 4:54 PM

tomek accepted this revision.Jun 13 2024, 10:46 AM

tomek added inline comments.

lib/hooks/qr-auth.js
131–136	This doesn't make too much sense to me. If we want to remove the device lists after restoration, shouldn't we simply not persist them? We've discussed this with @kamil and it seems like this solution is better than its alternatives.