Page MenuHomePhabricator

[Identity] send `IdentityDeviceListUpdated` after logout
ClosedPublic

Authored by kamil on Jun 10 2024, 5:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 1:16 PM
Unknown Object (File)
Tue, Oct 22, 9:04 AM
Unknown Object (File)
Tue, Oct 22, 8:34 AM
Unknown Object (File)
Sep 25 2024, 10:49 PM
Unknown Object (File)
Sep 25 2024, 10:49 PM
Unknown Object (File)
Sep 16 2024, 7:58 AM
Unknown Object (File)
Sep 15 2024, 8:28 AM
Unknown Object (File)
Sep 15 2024, 8:19 AM
Subscribers

Details

Summary

Part of ENG-7837.

Sending messages to devices remained on device list.

Depends on D12377

Test Plan
  1. Run local TB, and Identity, and make all clients connect to it.
  2. usingCommServicesAccessToken = true
  3. Login on multiple devices (2 devices of user A, 1 device of user B but A is aware of B).
  4. Log out on one of A's devices (the device that was last logged in - updates after login are not ready yet).
  5. Other A device should receive an update and fetch an updated device list
  6. B device should receive an update and fetch the device list for B

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Jun 10 2024, 9:52 AM

Besides that LGTM

services/identity/src/grpc_services/authenticated.rs
354–361 ↗(On Diff #41159)

Commented in D12377 - modifying send_device_list_update() to accept list of device IDs and creating a single tokio::spawn task for all of them might be more efficient.

This revision is now accepted and ready to land.Jun 13 2024, 3:14 AM