Page MenuHomePhabricator
Differential D12378

[Identity] send `IdentityDeviceListUpdated` after logout
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 5:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:12 PM
Unknown Object (File)
Sat, Mar 1, 11:15 AM
Unknown Object (File)
Sat, Mar 1, 7:36 AM
Unknown Object (File)
Sat, Mar 1, 7:36 AM
Unknown Object (File)
Sat, Mar 1, 2:38 AM
Unknown Object (File)
Thu, Feb 27, 10:08 PM
Unknown Object (File)
Mon, Feb 24, 11:14 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
View All 84 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
varun
Commits
rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout
Summary

Part of ENG-7837.

Sending messages to devices remained on device list.

Depends on D12377

Test Plan
  1. Run local TB, and Identity, and make all clients connect to it.
  2. usingCommServicesAccessToken = true
  3. Login on multiple devices (2 devices of user A, 1 device of user B but A is aware of B).
  4. Log out on one of A's devices (the device that was last logged in - updates after login are not ready yet).
  5. Other A device should receive an update and fetch an updated device list
  6. B device should receive an update and fetch the device list for B

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 5:06 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 5:06 AM
Harbormaster completed remote builds in B29572: Diff 41159.Jun 10 2024, 5:23 AM
kamil added a child revision: D12379: [lib] handle `DEVICE_LIST_UPDATED` message.Jun 10 2024, 8:52 AM
kamil mentioned this in D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.Jun 10 2024, 9:42 AM
kamil mentioned this in D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.
kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:46 AM
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Jun 10 2024, 9:52 AM
bartek added a comment.Jun 12 2024, 8:50 AM

Besides that LGTM

services/identity/src/grpc_services/authenticated.rs
354–361 ↗(On Diff #41159)

Commented in D12377 - modifying send_device_list_update() to accept list of device IDs and creating a single tokio::spawn task for all of them might be more efficient.

tomek accepted this revision.Jun 13 2024, 3:14 AM
This revision is now accepted and ready to land.Jun 13 2024, 3:14 AM
kamil updated this revision to Diff 41289.Jun 13 2024, 8:40 AM

address review

Harbormaster completed remote builds in B29665: Diff 41289.Jun 13 2024, 8:56 AM
Closed by commit rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM6488eee28c83: [lib] add `IdentityDeviceListUpdated` P2P message type.
kamil mentioned this in rCOMMafda4a8565f3: [lib] handle `IdentityDeviceListUpdated` P2P message.
kamil added a commit: rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout.
kamil mentioned this in D12438: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:30 AM
kamil mentioned this in rCOMM47f0ef750274: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:55 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
37 lines

Diff 41302

View Options

services/identity/src/grpc_services/authenticated.rs

Show All 35 Linespublic struct VideoInfo: Record {
var format: String = "N/A" var format: String = "N/A"
} }
public class MediaModule: Module { public class MediaModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("MediaModule") Name("MediaModule")
AsyncFunction("getVideoInfo", getVideoInfo) AsyncFunction("getVideoInfo", getVideoInfo)
AsyncFunction("hasMultipleFrames", hasMultipleFrames)
} }
// MARK: - Function implementations // MARK: - Function implementations
private func getVideoInfo(path: URL) throws -> VideoInfo { private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path) let asset = AVAsset(url: path)
Show All 15 Lines private func getVideoInfo(path: URL) throws -> VideoInfo {
} else { } else {
throw NoVideoTrackException(path) throw NoVideoTrackException(path)
} }
videoInfo.format = path.pathExtension videoInfo.format = path.pathExtension
return videoInfo return videoInfo
} }
private func hasMultipleFrames(path: URL) throws -> Bool {
guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
throw FailedToLoadGifException(path)
}
let count = CGImageSourceGetCount(imageSource)
return count > 1
}
} }
// MARK: - Exception definitions // MARK: - Exception definitions
private class NoVideoTrackException: GenericException<URL> { private class NoVideoTrackException: GenericException<URL> {
override var reason: String { override var reason: String {
"No video track found in file URI: \(param)" "No video track found in file URI: \(param)"
} }
} }
private class FailedToLoadGifException: GenericException<URL> {
override var reason: String {
"Failed to load gif at URI: \(param)"
}
}