Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/selectors/user-selectors.js | ||
|---|---|---|
| 225 ↗ | (On Diff #41156) | We should explain in a comment what we mean by foreign peer devices. |
| 236–239 ↗ | (On Diff #41156) | This doesn't hurt, but we don't need to repeat a condition that was used while filtering |
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
| 222 ↗ | (On Diff #41156) | Talked with @kamil about this call. This broadcast will happen on all the devices and not just on the primary. This isn't a correctness concern, because the payload doesn't include a device list and thus can't be outdated. From the performance point of view, this is wasteful but doesn't hurt us too much. But still, we can consider limiting the broadcast to be sent only from the primary. |
| 222–223 ↗ | (On Diff #41156) | We can consider broadcasting also to our devices which will simplify the logic a bit, but it's up to you. |
Comment Actions
- add comment
- remove obsolete condition
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 222–223 ↗ | (On Diff #41156) | Leaving as it is to avoid sending data trough network when we can handle it locally |