Details
Details
- Reviewers
bartek tomek - Commits
- rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message
Send this message to device and make sure it's processed
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 192 ↗ | (On Diff #41167) | Noticed that you decided to call this even if !result.valid. Can you share some context around that decision, and what it means if !result.valid? |
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 192 ↗ | (On Diff #41167) | This is to leave logs to check if the device list was properly signed by the primary device. However, currently, there is no full device list support and we have to support legacy Identity auth (that's the case where result.valid = false). I can add a code comment to make it more clear. |