Paths

Table of Contentst

Differential D12379

[lib] handle `DEVICE_LIST_UPDATED` message
ClosedPublic
Actions

Authored by kamil on Mon, Jun 10, 8:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 29, 6:47 PM

	Unknown Object (File)
	Tue, Jun 25, 1:33 PM

	Unknown Object (File)
	Fri, Jun 21, 2:38 PM

	Unknown Object (File)
	Fri, Jun 21, 5:59 AM

	Unknown Object (File)
	Wed, Jun 19, 8:45 PM

	Unknown Object (File)
	Wed, Jun 19, 12:48 PM

	Unknown Object (File)
	Mon, Jun 17, 5:35 PM

	Unknown Object (File)
	Mon, Jun 17, 4:53 PM

View All 18 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message

Summary

We want to call getAndUpdateDeviceListsForUsers on each request, leaving logs as in D12347

Depends on D12378

Test Plan

Send this message to device and make sure it's processed

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Jun 10, 8:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 10, 8:52 AM

kamil added a child revision: D12380: [lib] broadcast updates when becoming aware of new device existence.Mon, Jun 10, 8:59 AM

Harbormaster completed remote builds in B29576: Diff 41167.Mon, Jun 10, 9:12 AM

kamil published this revision for review.Mon, Jun 10, 9:52 AM

ashoat added inline comments.Mon, Jun 10, 1:40 PM

lib/tunnelbroker/use-peer-to-peer-message-handler.js
192 ↗	(On Diff #41167)	Noticed that you decided to call this even if `!result.valid`. Can you share some context around that decision, and what it means if `!result.valid`?

kamil added inline comments.Thu, Jun 13, 1:45 AM

lib/tunnelbroker/use-peer-to-peer-message-handler.js
192 ↗	(On Diff #41167)	This is to leave logs to check if the device list was properly signed by the primary device. However, currently, there is no full device list support and we have to support legacy Identity auth (that's the case where `result.valid = false`). I can add a code comment to make it more clear.

tomek accepted this revision.Thu, Jun 13, 3:15 AM

This revision is now accepted and ready to land.Thu, Jun 13, 3:15 AM

Closed by commit rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message (authored by kamil). · Explain WhyThu, Jun 13, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

11 lines

Diff 41303

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...