Page MenuHomePhabricator
Differential D12379

[lib] handle `DEVICE_LIST_UPDATED` message
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 8:52 AM.
Tags
None
Referenced Files
F3381883: D12379.diff
Thu, Nov 28, 6:58 AM
Unknown Object (File)
Mon, Nov 25, 12:45 AM
Unknown Object (File)
Sun, Nov 24, 11:37 PM
Unknown Object (File)
Sun, Nov 24, 8:46 PM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Sat, Nov 2, 12:01 AM
Unknown Object (File)
Sat, Nov 2, 12:01 AM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message
Summary

We want to call getAndUpdateDeviceListsForUsers on each request, leaving logs as in D12347

Depends on D12378

Test Plan

Send this message to device and make sure it's processed

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 10 2024, 8:52 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 8:52 AM
kamil added a child revision: D12380: [lib] broadcast updates when becoming aware of new device existence.Jun 10 2024, 8:59 AM
Harbormaster completed remote builds in B29576: Diff 41167.Jun 10 2024, 9:12 AM
kamil published this revision for review.Jun 10 2024, 9:52 AM
ashoat added inline comments.Jun 10 2024, 1:40 PM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
192

Noticed that you decided to call this even if !result.valid. Can you share some context around that decision, and what it means if !result.valid?

kamil added inline comments.Jun 13 2024, 1:45 AM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
192

This is to leave logs to check if the device list was properly signed by the primary device.

However, currently, there is no full device list support and we have to support legacy Identity auth (that's the case where result.valid = false). I can add a code comment to make it more clear.

tomek accepted this revision.Jun 13 2024, 3:15 AM
This revision is now accepted and ready to land.Jun 13 2024, 3:15 AM
Closed by commit rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
11 lines

Diff 41167

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...