Page MenuHomePhabricator
Differential D12374

[lib] factor out getting and updating device list to hook
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Fri, Feb 28, 2:01 AM
Unknown Object (File)
Feb 26 2025, 11:48 AM
Unknown Object (File)
Feb 26 2025, 8:49 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
View All 66 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook
Summary

We want to reuse this code in more places (later in the stack).

Depends on D12373

Test Plan

Test plan from D12330

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 4:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:32 AM
Harbormaster completed remote builds in B29567: Diff 41154.Jun 10 2024, 4:48 AM
kamil added a child revision: D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.Jun 10 2024, 4:54 AM
kamil published this revision for review.Jun 10 2024, 9:51 AM
tomek accepted this revision.Jun 12 2024, 5:53 AM
This revision is now accepted and ready to land.Jun 12 2024, 5:53 AM
bartek accepted this revision.Jun 12 2024, 8:55 AM
Closed by commit rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook.
kamil added a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Jun 13 2024, 9:37 AM
kamil removed a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Jun 17 2024, 4:20 AM
kamil added a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Jun 19 2024, 2:22 PM
kamil removed a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Jun 19 2024, 2:23 PM

Revision Contents
Changeset List

PathSize
lib/
handlers/
22 lines
hooks/
22 lines

Diff 41297

View Options

lib/handlers/user-infos-handler.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

lib/hooks/peer-list-hooks.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines