[Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client
ClosedPublic
Actions

Authored by kamil on Mon, Jun 10, 4:58 AM.

Details

Reviewers

bartek
tomek
varun

Commits

rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker…

Summary

Part of ENG-7837.

Sending message from Identity to device using Tunnelbroker - similar to RefreshKeyRequest.

Depends on D12376

Test Plan

Call this method and check if message was queued on Tunnelbroker.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Jun 10, 4:58 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 10, 4:58 AM

kamil added a child revision: D12378: [Identity] send `IdentityDeviceListUpdated` after logout.Mon, Jun 10, 5:06 AM

Harbormaster completed remote builds in B29570: Diff 41157.Mon, Jun 10, 5:14 AM

kamil published this revision for review.Mon, Jun 10, 9:51 AM

bartek accepted this revision.Wed, Jun 12, 8:45 AM

This revision is now accepted and ready to land.Wed, Jun 12, 8:45 AM

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

bartek mentioned this in D12378: [Identity] send `IdentityDeviceListUpdated` after logout.Wed, Jun 12, 8:50 AM

refactor to use array od device IDs

In D12377#352213, @bartek wrote:

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

Good call

Harbormaster completed remote builds in B29664: Diff 41288.Thu, Jun 13, 8:55 AM

Closed by commit rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker… (authored by kamil). · Explain WhyThu, Jun 13, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker….

kamil mentioned this in D12438: [terraform] Deploy Identity `0.23-staging` to staging.Fri, Jun 14, 2:30 AM

kamil mentioned this in rCOMM47f0ef750274: [terraform] Deploy Identity `0.23-staging` to staging.Fri, Jun 14, 2:55 AM