Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
-
tunnelbroker.rs

[Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:58 AM.

Details

Reviewers

bartek
tomek
varun

Commits

rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker…

Summary

Part of ENG-7837.

Sending message from Identity to device using Tunnelbroker - similar to RefreshKeyRequest.

Depends on D12376

Test Plan

Call this method and check if message was queued on Tunnelbroker.

Diff Detail

Repository

rCOMM Comm

Branch

peer-list-3

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 10 2024, 4:58 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:58 AM

kamil added a child revision: D12378: [Identity] send `IdentityDeviceListUpdated` after logout.Jun 10 2024, 5:06 AM

Harbormaster completed remote builds in B29570: Diff 41157.Jun 10 2024, 5:14 AM

kamil published this revision for review.Jun 10 2024, 9:51 AM

bartek accepted this revision.Jun 12 2024, 8:45 AM

This revision is now accepted and ready to land.Jun 12 2024, 8:45 AM

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

bartek mentioned this in D12378: [Identity] send `IdentityDeviceListUpdated` after logout.Jun 12 2024, 8:50 AM

refactor to use array od device IDs

In D12377#352213, @bartek wrote:

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

Good call

Harbormaster completed remote builds in B29664: Diff 41288.Jun 13 2024, 8:55 AM

Closed by commit rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker… (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker….

kamil mentioned this in D12438: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:30 AM

kamil mentioned this in rCOMM47f0ef750274: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:55 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

tunnelbroker.rs

20 lines

Diff 41157

View Options

services/identity/src/tunnelbroker.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines	onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
}		}
};		};

keyboardShow = (event: KeyboardEvent) => {		keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar,		// flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom		// but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions;		const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;		const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({		const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement		// Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height,		android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0),		default: Math.max(event.endCoordinates.height - bottomInset, 0),
});		});
const keyboardShownHeight =		const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);		inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight;		this.keyboardShownHeight = keyboardShownHeight;

▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines

[Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker clientClosedPublicActions