Page MenuHomePhabricator
Differential D12372

[lib] convert `peerToPeerMessageHandler` to a hook
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 12:58 PM
Unknown Object (File)
Mon, Apr 7, 10:48 AM
Unknown Object (File)
Mon, Apr 7, 10:14 AM
Unknown Object (File)
Mon, Apr 7, 7:29 AM
Unknown Object (File)
Sun, Apr 6, 1:33 AM
Unknown Object (File)
Mar 5 2025, 8:08 PM
Unknown Object (File)
Mar 3 2025, 6:48 AM
Unknown Object (File)
Mar 3 2025, 6:47 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM82d5ff08dc09: [lib] convert `peerToPeerMessageHandler` to a hook
Summary

Avoids passing a lot of callbacks as arguments and makes code easier to maintain.

Depends on D12371

Test Plan

Flow - this is just moving code to a hook, logic remains unchanged. Functionality tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 41296

View Options

lib/handlers/peer-to-peer-message-handler.js

// @flow // @flow
import { type BaseStoreOpsHandlers } from './base-ops.js'; import { type BaseStoreOpsHandlers } from './base-ops.js';
import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { import type {
ClientDBThreadInfo, ClientDBThreadInfo,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ThreadStore, ThreadStore,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo, convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
} from '../utils/thread-ops-utils.js'; } from '../utils/thread-ops-utils.js';
export type RemoveThreadOperation = { export type RemoveThreadOperation = {
Show All 24 Linesexport type ClientDBThreadStoreOperation =
| RemoveThreadOperation | RemoveThreadOperation
| RemoveAllThreadsOperation | RemoveAllThreadsOperation
| ClientDBReplaceThreadOperation; | ClientDBReplaceThreadOperation;
export const threadStoreOpsHandlers: BaseStoreOpsHandlers< export const threadStoreOpsHandlers: BaseStoreOpsHandlers<
ThreadStore, ThreadStore,
ThreadStoreOperation, ThreadStoreOperation,
ClientDBThreadStoreOperation, ClientDBThreadStoreOperation,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ClientDBThreadInfo, ClientDBThreadInfo,
> = { > = {
processStoreOperations( processStoreOperations(
store: ThreadStore, store: ThreadStore,
ops: $ReadOnlyArray<ThreadStoreOperation>, ops: $ReadOnlyArray<ThreadStoreOperation>,
): ThreadStore { ): ThreadStore {
if (ops.length === 0) { if (ops.length === 0) {
return store; return store;
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/peer-to-peer-message-handler.js

// @flow // @flow
import { type BaseStoreOpsHandlers } from './base-ops.js'; import { type BaseStoreOpsHandlers } from './base-ops.js';
import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { import type {
ClientDBThreadInfo, ClientDBThreadInfo,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ThreadStore, ThreadStore,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo, convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
} from '../utils/thread-ops-utils.js'; } from '../utils/thread-ops-utils.js';
export type RemoveThreadOperation = { export type RemoveThreadOperation = {
Show All 24 Linesexport type ClientDBThreadStoreOperation =
| RemoveThreadOperation | RemoveThreadOperation
| RemoveAllThreadsOperation | RemoveAllThreadsOperation
| ClientDBReplaceThreadOperation; | ClientDBReplaceThreadOperation;
export const threadStoreOpsHandlers: BaseStoreOpsHandlers< export const threadStoreOpsHandlers: BaseStoreOpsHandlers<
ThreadStore, ThreadStore,
ThreadStoreOperation, ThreadStoreOperation,
ClientDBThreadStoreOperation, ClientDBThreadStoreOperation,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ClientDBThreadInfo, ClientDBThreadInfo,
> = { > = {
processStoreOperations( processStoreOperations(
store: ThreadStore, store: ThreadStore,
ops: $ReadOnlyArray<ThreadStoreOperation>, ops: $ReadOnlyArray<ThreadStoreOperation>,
): ThreadStore { ): ThreadStore {
if (ops.length === 0) { if (ops.length === 0) {
return store; return store;
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

// @flow // @flow
import { type BaseStoreOpsHandlers } from './base-ops.js'; import { type BaseStoreOpsHandlers } from './base-ops.js';
import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { import type {
ClientDBThreadInfo, ClientDBThreadInfo,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ThreadStore, ThreadStore,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo, convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
} from '../utils/thread-ops-utils.js'; } from '../utils/thread-ops-utils.js';
export type RemoveThreadOperation = { export type RemoveThreadOperation = {
Show All 24 Linesexport type ClientDBThreadStoreOperation =
| RemoveThreadOperation | RemoveThreadOperation
| RemoveAllThreadsOperation | RemoveAllThreadsOperation
| ClientDBReplaceThreadOperation; | ClientDBReplaceThreadOperation;
export const threadStoreOpsHandlers: BaseStoreOpsHandlers< export const threadStoreOpsHandlers: BaseStoreOpsHandlers<
ThreadStore, ThreadStore,
ThreadStoreOperation, ThreadStoreOperation,
ClientDBThreadStoreOperation, ClientDBThreadStoreOperation,
MinimallyEncodedRawThreadInfos, RawThreadInfos,
ClientDBThreadInfo, ClientDBThreadInfo,
> = { > = {
processStoreOperations( processStoreOperations(
store: ThreadStore, store: ThreadStore,
ops: $ReadOnlyArray<ThreadStoreOperation>, ops: $ReadOnlyArray<ThreadStoreOperation>,
): ThreadStore { ): ThreadStore {
if (ops.length === 0) { if (ops.length === 0) {
return store; return store;
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines