Page MenuHomePhabricator
Differential D12347

[lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional
ClosedPublic
Actions

Authored by kamil on Jun 7 2024, 2:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 6:41 PM
Unknown Object (File)
Mon, Mar 3, 6:47 AM
Unknown Object (File)
Mon, Mar 3, 6:26 AM
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Wed, Feb 26, 9:57 PM
Unknown Object (File)
Feb 14 2025, 10:59 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
View All 66 Files
Subscribers
ashoat
bartek

Details

Reviewers
bartek
tomek
Commits
rCOMM36192d5aac81: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional
Summary

To standardize sending updates for all Identity auth (legacy/QR-code) we need to remove signedDeviceList. However, @bartek added additional check for broadcasted and Identity device list equality and we want to keep it for now.

Depends on D12330

Test Plan

Flow - functionality tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 7 2024, 2:26 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 7 2024, 2:26 AM
Harbormaster failed remote builds in B29520: Diff 41093!Jun 7 2024, 2:31 AM
kamil published this revision for review.Jun 7 2024, 2:39 AM
bartek accepted this revision.Jun 7 2024, 4:25 AM
bartek added inline comments.
lib/handlers/peer-to-peer-message-handler.js
179–185 ↗(On Diff #41093)

Yeah it's good to leave this check for debugging device list updates. Finally, it will be a non-breaking change to remove signedDeviceList from the message type.

This revision is now accepted and ready to land.Jun 7 2024, 4:25 AM
ashoat added inline comments.Jun 7 2024, 8:06 AM
lib/handlers/peer-to-peer-message-handler.js
179–185 ↗(On Diff #41093)

This console.log will eventually be removed, yeah?

kamil added a child revision: D12373: [lib] factor out broadcasting device list updates to hook.Jun 10 2024, 4:25 AM
kamil mentioned this in D12379: [lib] handle `DEVICE_LIST_UPDATED` message.Jun 10 2024, 8:52 AM
kamil added inline comments.Jun 13 2024, 7:47 AM
lib/handlers/peer-to-peer-message-handler.js
179–185 ↗(On Diff #41093)

yes

This revision was landed with ongoing or failed builds.Jun 13 2024, 9:08 AM
Closed by commit rCOMM36192d5aac81: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM36192d5aac81: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional.
kamil mentioned this in rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message.

Revision Contents
Changeset List

PathSize
lib/
handlers/
15 lines
types/
tunnelbroker/
4 lines

Diff 41294

View Options

lib/handlers/peer-to-peer-message-handler.js

Show All 35 Linespublic struct VideoInfo: Record {
var format: String = "N/A" var format: String = "N/A"
} }
public class MediaModule: Module { public class MediaModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("MediaModule") Name("MediaModule")
AsyncFunction("getVideoInfo", getVideoInfo) AsyncFunction("getVideoInfo", getVideoInfo)
AsyncFunction("hasMultipleFrames", hasMultipleFrames)
} }
// MARK: - Function implementations // MARK: - Function implementations
private func getVideoInfo(path: URL) throws -> VideoInfo { private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path) let asset = AVAsset(url: path)
Show All 15 Lines private func getVideoInfo(path: URL) throws -> VideoInfo {
} else { } else {
throw NoVideoTrackException(path) throw NoVideoTrackException(path)
} }
videoInfo.format = path.pathExtension videoInfo.format = path.pathExtension
return videoInfo return videoInfo
} }
private func hasMultipleFrames(path: URL) throws -> Bool {
guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
throw FailedToLoadGifException(path)
}
let count = CGImageSourceGetCount(imageSource)
return count > 1
}
} }
// MARK: - Exception definitions // MARK: - Exception definitions
private class NoVideoTrackException: GenericException<URL> { private class NoVideoTrackException: GenericException<URL> {
override var reason: String { override var reason: String {
"No video track found in file URI: \(param)" "No video track found in file URI: \(param)"
} }
} }
private class FailedToLoadGifException: GenericException<URL> {
override var reason: String {
"Failed to load gif at URI: \(param)"
}
}
View Options

lib/types/tunnelbroker/peer-to-peer-message-types.js

Show All 35 Linespublic struct VideoInfo: Record {
var format: String = "N/A" var format: String = "N/A"
} }
public class MediaModule: Module { public class MediaModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("MediaModule") Name("MediaModule")
AsyncFunction("getVideoInfo", getVideoInfo) AsyncFunction("getVideoInfo", getVideoInfo)
AsyncFunction("hasMultipleFrames", hasMultipleFrames)
} }
// MARK: - Function implementations // MARK: - Function implementations
private func getVideoInfo(path: URL) throws -> VideoInfo { private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path) let asset = AVAsset(url: path)
Show All 15 Lines private func getVideoInfo(path: URL) throws -> VideoInfo {
} else { } else {
throw NoVideoTrackException(path) throw NoVideoTrackException(path)
} }
videoInfo.format = path.pathExtension videoInfo.format = path.pathExtension
return videoInfo return videoInfo
} }
private func hasMultipleFrames(path: URL) throws -> Bool {
guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
throw FailedToLoadGifException(path)
}
let count = CGImageSourceGetCount(imageSource)
return count > 1
}
} }
// MARK: - Exception definitions // MARK: - Exception definitions
private class NoVideoTrackException: GenericException<URL> { private class NoVideoTrackException: GenericException<URL> {
override var reason: String { override var reason: String {
"No video track found in file URI: \(param)" "No video track found in file URI: \(param)"
} }
} }
private class FailedToLoadGifException: GenericException<URL> {
override var reason: String {
"Failed to load gif at URI: \(param)"
}
}