Page MenuHomePhabricator

[Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client
ClosedPublic

Authored by kamil on Jun 10 2024, 4:58 AM.
Tags
None
Referenced Files
F3382381: D12377.diff
Thu, Nov 28, 10:28 AM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Mon, Nov 11, 6:49 AM
Unknown Object (File)
Mon, Nov 11, 2:46 AM
Unknown Object (File)
Sun, Nov 10, 7:17 PM
Unknown Object (File)
Sun, Nov 10, 9:00 AM
Unknown Object (File)
Fri, Nov 8, 7:14 PM
Subscribers

Details

Summary

Part of ENG-7837.

Sending message from Identity to device using Tunnelbroker - similar to RefreshKeyRequest.

Depends on D12376

Test Plan

Call this method and check if message was queued on Tunnelbroker.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jun 10 2024, 9:51 AM
This revision is now accepted and ready to land.Jun 12 2024, 8:45 AM

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

refactor to use array od device IDs

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

Good call