Page MenuHomePhabricator
Differential D12430

[lib] broadcast updates to all peers after Secondary Device registration success
ClosedPublic
Actions

Authored by kamil on Jun 13 2024, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 2:38 PM
Unknown Object (File)
Sat, Oct 26, 4:36 PM
Unknown Object (File)
Oct 24 2024, 4:05 AM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
View All 47 Files
Subscribers
ashoat
bartek

Details

Reviewers
bartek
tomek
Commits
rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success
Summary

After discussion with @bartek we concluded that after receiving SECONDARY_DEVICE_REGISTRATION_SUCCESS we should:

  1. Broadcast update to all peers
  2. Update our own store (we have to call getAndUpdateDeviceListsForUsers to get platform details of new device).

Depends on D12374

Test Plan

Going to test along with fixes to ENG-8385.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 13 2024, 9:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 13 2024, 9:37 AM
kamil published this revision for review.Jun 13 2024, 9:51 AM
Harbormaster completed remote builds in B29669: Diff 41306.Jun 13 2024, 9:53 AM
bartek accepted this revision.Jun 13 2024, 9:54 PM
This revision is now accepted and ready to land.Jun 13 2024, 9:54 PM
kamil edited parent revisions, added: D12455: [lib] broadcast device list updates after Tunnelbroker socket connection is established; removed: D12374: [lib] factor out getting and updating device list to hook.Jun 17 2024, 4:20 AM
kamil updated this revision to Diff 41503.Jun 19 2024, 2:22 PM
kamil added a parent revision: D12374: [lib] factor out getting and updating device list to hook.

rebase before landing

kamil removed a parent revision: D12374: [lib] factor out getting and updating device list to hook.Jun 19 2024, 2:23 PM
kamil added a child revision: D12478: [lib][web][native] improve naming in `QRAuthProvider`.Jun 19 2024, 2:33 PM
Harbormaster completed remote builds in B29780: Diff 41503.Jun 19 2024, 2:53 PM
Closed by commit rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success (authored by kamil). · Explain WhyJun 19 2024, 3:00 PM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success.
kamil mentioned this in D13963: [lib] create hook to run Device List Update Protocol.Tue, Nov 19, 6:44 AM

Revision Contents
Changeset List

PathSize
native/
profile/
35 lines

Diff 41514

View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...