Page MenuHomePhabricator
Differential D12430

[lib] broadcast updates to all peers after Secondary Device registration success
ClosedPublic
Actions

Authored by kamil on Thu, Jun 13, 9:37 AM.
Tags
None
Referenced Files
F2109996: D12430.id41515.diff
Tue, Jun 25, 6:18 PM
F2109613: D12430.id41504.diff
Tue, Jun 25, 5:03 PM
Unknown Object (File)
Mon, Jun 24, 6:30 PM
Unknown Object (File)
Sun, Jun 23, 1:45 PM
Unknown Object (File)
Fri, Jun 21, 6:23 AM
Unknown Object (File)
Fri, Jun 21, 6:22 AM
Unknown Object (File)
Thu, Jun 20, 1:13 AM
Unknown Object (File)
Wed, Jun 19, 1:11 AM
View All 12 Files
Subscribers
ashoat
bartek

Details

Reviewers
bartek
tomek
Commits
rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success
Summary

After discussion with @bartek we concluded that after receiving SECONDARY_DEVICE_REGISTRATION_SUCCESS we should:

  1. Broadcast update to all peers
  2. Update our own store (we have to call getAndUpdateDeviceListsForUsers to get platform details of new device).

Depends on D12374

Test Plan

Going to test along with fixes to ENG-8385.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Jun 13, 9:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 13, 9:37 AM
kamil published this revision for review.Thu, Jun 13, 9:51 AM
Harbormaster completed remote builds in B29669: Diff 41306.Thu, Jun 13, 9:53 AM
bartek accepted this revision.Thu, Jun 13, 9:54 PM
This revision is now accepted and ready to land.Thu, Jun 13, 9:54 PM
kamil edited parent revisions, added: D12455: [lib] broadcast device list updates after Tunnelbroker socket connection is established; removed: D12374: [lib] factor out getting and updating device list to hook.Mon, Jun 17, 4:20 AM
kamil updated this revision to Diff 41503.Wed, Jun 19, 2:22 PM
kamil added a parent revision: D12374: [lib] factor out getting and updating device list to hook.

rebase before landing

kamil removed a parent revision: D12374: [lib] factor out getting and updating device list to hook.Wed, Jun 19, 2:23 PM
kamil added a child revision: D12478: [lib][web][native] improve naming in `QRAuthProvider`.Wed, Jun 19, 2:33 PM
Harbormaster completed remote builds in B29780: Diff 41503.Wed, Jun 19, 2:53 PM
Closed by commit rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success (authored by kamil). · Explain WhyWed, Jun 19, 3:00 PM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success.

Revision Contents
Changeset List

PathSize
native/
profile/
35 lines

Diff 41514

View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...