Paths

Table of Contentst

Differential D12450

[web] update QR login flow to use `QRAuthContext`
ClosedPublic
Actions

Authored by kamil on Mon, Jun 17, 3:55 AM.

Tags

None

Referenced Files

	F2109183: D12450.id41510.diff
	Tue, Jun 25, 3:32 PM

	F2108819: D12450.diff
	Tue, Jun 25, 2:23 PM

	F2107170: D12450.id41500.diff
	Tue, Jun 25, 9:38 AM

	Unknown Object (File)
	Mon, Jun 24, 6:30 PM

	Unknown Object (File)
	Mon, Jun 24, 12:05 PM

	Unknown Object (File)
	Mon, Jun 24, 10:46 AM

	Unknown Object (File)
	Mon, Jun 24, 4:03 AM

	Unknown Object (File)
	Sun, Jun 23, 4:14 AM

View All 15 Files

Subscribers

Details

Reviewers

bartek
ashoat

Commits

rCOMM69332152efe6: [web] update QR login flow to use `QRAuthContext`

Summary

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Rendering context and de-duplicating logic.

Depends on D12449

Test Plan

Test QR login flow on web. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Jun 17, 3:55 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jun 17, 3:55 AM

kamil added a child revision: D12452: [native] update QR login flow to use `QRAuthContext`.Mon, Jun 17, 4:02 AM

Harbormaster completed remote builds in B29713: Diff 41382.Mon, Jun 17, 4:11 AM

kamil published this revision for review.Mon, Jun 17, 4:36 AM

bartek accepted this revision.Mon, Jun 17, 4:46 AM

This revision is now accepted and ready to land.Mon, Jun 17, 4:46 AM

ashoat accepted this revision.Mon, Jun 17, 10:07 AM

rebase

Harbormaster completed remote builds in B29776: Diff 41499.Wed, Jun 19, 2:35 PM

Closed by commit rCOMM69332152efe6: [web] update QR login flow to use `QRAuthContext` (authored by kamil). · Explain WhyWed, Jun 19, 3:00 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM69332152efe6: [web] update QR login flow to use `QRAuthContext`.

Revision Contents
Changeset List

Path

Size

web/

account/

qr-code-login.react.js

58 lines

35 lines

utils/

qr-code-utils.js

6 lines

Diff 41509

web/account/qr-code-login.react.js

Loading...

web/app.react.js

Loading...

web/utils/qr-code-utils.js

Loading...