Paths

Table of Contentst

Differential D12478

[lib][web][native] improve naming in `QRAuthProvider`
ClosedPublic
Actions

Authored by kamil on Jun 19 2024, 9:33 PM.

Details

Reviewers

bartek

Commits

rCOMM49a75b90db1a: [lib][web][native] improve naming in `QRAuthProvider`

Summary

After addressing review in the stack the naming is still not really cohesive. Renaming some functions to improve readability.

Depends on D12430

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 19 2024, 9:33 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 19 2024, 9:33 PM

login -> logIn

Harbormaster completed remote builds in B29781: Diff 41504.Jun 19 2024, 9:57 PM

kamil published this revision for review.Jun 19 2024, 10:00 PM

Harbormaster completed remote builds in B29782: Diff 41505.Jun 19 2024, 10:04 PM

bartek accepted this revision.Jun 20 2024, 8:38 AM

This revision is now accepted and ready to land.Jun 20 2024, 8:38 AM

Closed by commit rCOMM49a75b90db1a: [lib][web][native] improve naming in `QRAuthProvider`. · Explain WhyJun 20 2024, 8:46 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM49a75b90db1a: [lib][web][native] improve naming in `QRAuthProvider`.

Revision Contents
Changeset List

Path

Size

lib/

components/

qr-auth-provider.react.js

24 lines

native/

qr-code/

qr-code-utils.js

10 lines

root.react.js

14 lines

web/

app.react.js

18 lines

utils/

qr-code-utils.js

10 lines

Diff 41543

View Options

lib/components/qr-auth-provider.react.js

View Options

native/qr-code/qr-code-utils.js

View Options

native/root.react.js

View Options

web/app.react.js

View Options

web/utils/qr-code-utils.js

[lib][web][native] improve naming in `QRAuthProvider`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41543

lib/components/qr-auth-provider.react.js

native/qr-code/qr-code-utils.js

native/root.react.js

web/app.react.js

web/utils/qr-code-utils.js

[lib][web][native] improve naming in `QRAuthProvider`
ClosedPublic
Actions

Revision Contents
Changeset List