Page MenuHomePhabricator

[lib] improve handling Tunnelbroker socket state
ClosedPublic

Authored by kamil on Fri, Jun 14, 5:37 AM.
Tags
None
Referenced Files
F2065845: D12440.id41337.diff
Fri, Jun 21, 11:07 AM
F2061665: D12440.id41336.diff
Fri, Jun 21, 12:15 AM
Unknown Object (File)
Thu, Jun 20, 11:45 AM
Unknown Object (File)
Wed, Jun 19, 7:19 PM
Unknown Object (File)
Mon, Jun 17, 10:30 PM
Unknown Object (File)
Mon, Jun 17, 10:29 PM
Subscribers

Details

Summary

Previously there was an edge case:

  1. Tunnelbroker socket state is connected: true and isAuthorized: false
  2. After calling setUnauthorizedDeviceID(false) the state is connected: true and isAuthorized: true, but the connection is still opened using the unauthorized type
  3. Next, the socket is closed and the state is connected: false and isAuthorized: true
  4. After the authenticating socket is in state connected: true and isAuthorized: true

As you can see - both 2 and 4 return the same result, but point 2 is not correct. This diff fixes this.

This bug can cause issues described in ENG-8385

Test Plan

Test switching from unauthorized to authorized session

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable