HomePhabricator
Diffusion Comm 3b4e4d7317ed

[lib] improve handling Tunnelbroker socket state

Description

[lib] improve handling Tunnelbroker socket state

Summary:
Previously there was an edge case:

  1. Tunnelbroker socket state is connected: true and isAuthorized: false
  2. After calling setUnauthorizedDeviceID(false) the state is connected: true and isAuthorized: true, but the connection is still opened using the unauthorized type
  3. Next, the socket is closed and the state is connected: false and isAuthorized: true
  4. After the authenticating socket is in state connected: true and isAuthorized: true

As you can see - both 2 and 4 return the same result, but point 2 is not correct. This diff fixes this.

This bug can cause issues described in ENG-8385

Test Plan: Test switching from unauthorized to authorized session

Reviewers: bartek, tomek

Reviewed By: bartek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D12440

Details

Provenance
kamilAuthored on Jun 14 2024, 5:25 AM
Reviewer
bartek
Differential Revision
D12440: [lib] improve handling Tunnelbroker socket state
Parents
rCOMM0d9a8a7d2f8a: [lib] introduce DISABLE_CONNECT_FARCASTER_ALERT gate
Branches
Unknown
Tags
Unknown