[lib] implement `QRAuthContext`
ClosedPublic
Actions

Authored by kamil on Mon, Jun 17, 3:51 AM.

Details

Reviewers

bartek
ashoat

Commits

rCOMM6f2164a8ee48: [lib] implement `QRAuthContext`

Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

This wraps the platform-specific logic to a context. Usage later in the stack.

Depends on D12445

Test Plan

Tested later in the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Jun 17, 3:51 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jun 17, 3:51 AM

kamil added a child revision: D12450: [web] update QR login flow to use `QRAuthContext`.Mon, Jun 17, 3:55 AM

Harbormaster completed remote builds in B29712: Diff 41381.Mon, Jun 17, 4:07 AM

kamil published this revision for review.Mon, Jun 17, 4:35 AM

kamil added inline comments.

lib/components/qr-auth-provider.react.js
54 ↗	(On Diff #41381)
58–104 ↗	(On Diff #41381)	this is unified code from both web and native `QRCodeScreen`

ashoat accepted this revision.Mon, Jun 17, 10:07 AM

ashoat added inline comments.

lib/components/qr-auth-provider.react.js
17 ↗	(On Diff #41381)	I think we need `mixed` instead of `Error` Can we be more specific in the naming here? It seems to only handle registration errors, not eg. QR code generation errors
74 ↗	(On Diff #41381)	Nit: should we call this `performLogIn` instead of `performRegistration`? I'm slightly worried that the reader might think this does registration when it can only do login