[web][native] extract QR code login functions to separate files
ClosedPublic
Actions

Authored by kamil on Jun 17 2024, 2:56 AM.

Details

Reviewers

bartek
ashoat

Commits

rCOMMc3e4fb49a47a: [web][native] extract QR code login functions to separate files

Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is, because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

This diff purpose is to move some functions to separate places to later pass it as props to a context.

Depends on D12440

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 17 2024, 2:56 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 17 2024, 2:56 AM

Harbormaster completed remote builds in B29707: Diff 41376.Jun 17 2024, 3:12 AM

rename

kamil added a child revision: D12449: [lib] implement `QRAuthContext`.Jun 17 2024, 3:51 AM

kamil edited the test plan for this revision. (Show Details)Jun 17 2024, 3:52 AM

Harbormaster completed remote builds in B29711: Diff 41380.Jun 17 2024, 4:10 AM

kamil published this revision for review.Jun 17 2024, 4:33 AM

bartek accepted this revision.Jun 17 2024, 4:41 AM

This revision is now accepted and ready to land.Jun 17 2024, 4:41 AM

ashoat accepted this revision.Jun 17 2024, 8:26 AM

ashoat added inline comments.

native/qr-code/qr-code-utils.js
63 ↗	(On Diff #41380)	In JS, there's no guarantee that something thrown is an `Error`.
web/utils/qr-code-utils.js
58 ↗	(On Diff #41380)	Same here
61 ↗	(On Diff #41380)