[lib] broadcast updates to all peers after Secondary Device registration success
ClosedPublic
Actions

Authored by kamil on Jun 13 2024, 4:37 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success

Summary

After discussion with @bartek we concluded that after receiving SECONDARY_DEVICE_REGISTRATION_SUCCESS we should:

Broadcast update to all peers
Update our own store (we have to call getAndUpdateDeviceListsForUsers to get platform details of new device).

Depends on D12374

Test Plan

Going to test along with fixes to ENG-8385.

Diff Detail

Repository

rCOMM Comm

Branch

fix-qr-code

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 13 2024, 4:37 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 13 2024, 4:37 PM

kamil published this revision for review.Jun 13 2024, 4:51 PM

Harbormaster completed remote builds in B29669: Diff 41306.Jun 13 2024, 4:53 PM

bartek accepted this revision.Jun 14 2024, 4:54 AM

This revision is now accepted and ready to land.Jun 14 2024, 4:54 AM

kamil edited parent revisions, added: D12455: [lib] broadcast device list updates after Tunnelbroker socket connection is established; removed: D12374: [lib] factor out getting and updating device list to hook.Jun 17 2024, 11:20 AM

rebase before landing

kamil removed a parent revision: D12374: [lib] factor out getting and updating device list to hook.Jun 19 2024, 9:23 PM

kamil added a child revision: D12478: [lib][web][native] improve naming in `QRAuthProvider`.Jun 19 2024, 9:33 PM

Harbormaster completed remote builds in B29780: Diff 41503.Jun 19 2024, 9:53 PM

Closed by commit rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success. · Explain WhyJun 19 2024, 10:00 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success.

kamil mentioned this in D13963: [lib] create hook to run Device List Update Protocol.Nov 19 2024, 2:44 PM

Revision Contents
Changeset List

Path

Size

native/

profile/

secondary-device-qr-code-scanner.react.js

35 lines

Diff 41503

View Options

native/profile/secondary-device-qr-code-scanner.react.js

[lib] broadcast updates to all peers after Secondary Device registration successClosedPublicActions