Page MenuHomePhabricator
Differential D12374

[lib] factor out getting and updating device list to hook
ClosedPublic
Actions

Authored by kamil on Mon, Jun 10, 4:32 AM.
Tags
None
Referenced Files
F2156331: D12374.diff
Sun, Jun 30, 11:44 PM
F2146939: D12374.id41297.diff
Sun, Jun 30, 12:39 AM
Unknown Object (File)
Mon, Jun 24, 4:20 PM
Unknown Object (File)
Sun, Jun 23, 6:41 PM
Unknown Object (File)
Sat, Jun 22, 5:29 AM
Unknown Object (File)
Fri, Jun 21, 8:57 AM
Unknown Object (File)
Thu, Jun 20, 4:20 PM
Unknown Object (File)
Thu, Jun 20, 2:05 PM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook
Summary

We want to reuse this code in more places (later in the stack).

Depends on D12373

Test Plan

Test plan from D12330

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mon, Jun 10, 4:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Jun 10, 4:32 AM
Harbormaster completed remote builds in B29567: Diff 41154.Mon, Jun 10, 4:48 AM
kamil added a child revision: D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.Mon, Jun 10, 4:54 AM
kamil published this revision for review.Mon, Jun 10, 9:51 AM
tomek accepted this revision.Wed, Jun 12, 5:53 AM
This revision is now accepted and ready to land.Wed, Jun 12, 5:53 AM
bartek accepted this revision.Wed, Jun 12, 8:55 AM
Closed by commit rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook (authored by kamil). · Explain WhyThu, Jun 13, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook.
kamil added a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Thu, Jun 13, 9:37 AM
kamil removed a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Mon, Jun 17, 4:20 AM
kamil added a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Wed, Jun 19, 2:22 PM
kamil removed a child revision: D12430: [lib] broadcast updates to all peers after Secondary Device registration success.Wed, Jun 19, 2:23 PM

Revision Contents
Changeset List

PathSize
lib/
handlers/
22 lines
hooks/
22 lines

Diff 41154

View Options

lib/handlers/user-infos-handler.react.js

Loading...
View Options

lib/hooks/peer-list-hooks.js

Loading...