Page MenuHomePhabricator
Differential D11479

[keyserver] add file-type dep
ClosedPublic
Actions

Authored by ginsu on Mar 29 2024, 1:00 PM.
Tags
None
Referenced Files
F5416330: D11479.id38553.diff
Thu, Apr 10, 4:42 AM
F5391664: D11479.id38558.diff
Wed, Apr 9, 10:33 PM
Unknown Object (File)
Fri, Apr 4, 8:34 PM
Unknown Object (File)
Sun, Mar 30, 3:08 PM
Unknown Object (File)
Sat, Mar 29, 8:48 AM
Unknown Object (File)
Fri, Mar 28, 4:40 PM
Unknown Object (File)
Mar 4 2025, 9:46 AM
Unknown Object (File)
Feb 26 2025, 11:34 AM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
Commits
rCOMM194afd3f0228: [keyserver] add file-type dep
Summary

Added the file-type dependency to keyserver.package.json and ran yarn cleaninstall

Test Plan

n/a

Diff Detail

Repository
rCOMM Comm
Branch
eng-7599
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
1 line

Diff 38553

View Options

keyserver/package.json

  • This file was added.
// @flow
import type { CommunityInfo } from 'lib/types/community-types.js';
import { dbQuery, SQL } from '../database/database.js';
import { Viewer } from '../session/viewer.js';
type ServerCommunityInfoWithHolder = {
...CommunityInfo,
+id: string,
+blobHolder: ?string,
};
tomekUnsubmitted
Not Done
Inline Actions
import { Viewer } from '../session/viewer.js';
- type ServerCommunityInfoWithHolder = {
+ type ServerCommunityInfoWithHolder = $ReadOnly<{
...CommunityInfo,
+id: string,
+blobHolder: ?string,
- };
+ }>;
async function fetchCommunityInfos(

We should make this readonly because spreading a type makes it writable.

tomek: We should make this readonly because spreading a type makes it writable.
async function fetchCommunityInfos(
viewer: Viewer,
): Promise<$ReadOnlyArray<ServerCommunityInfoWithHolder>> {
if (!viewer) {
return [];
}
const query = SQL`
SELECT c.id, c.farcaster_channel_id as farcasterChannelID,
c.blob_holder as blobHolder
FROM communities c
INNER JOIN memberships m
ON c.id = m.thread AND m.user = ${viewer.userID}
WHERE m.role > 0
`;
const [result] = await dbQuery(query);
const communityInfos = result.map(row => {
return {
id: row.id.toString(),
farcasterChannelID: row.farcasterChannelID,
blobHolder: row.blobHolder,
};
});
tomekUnsubmitted
Not Done
Inline Actions
const [result] = await dbQuery(query);
- const communityInfos = result.map(row => {
- return {
+ const communityInfos = result.map(row => ({
id: row.id.toString(),
farcasterChannelID: row.farcasterChannelID,
blobHolder: row.blobHolder,
- };
});
return communityInfos;
tomek:
return communityInfos;
}
export { fetchCommunityInfos };