Page MenuHomePhabricator
Differential D11688

[native] Purge the store after clearing the DB
ClosedPublic
Actions

Authored by tomek on Apr 18 2024, 7:36 AM.
Tags
None
Referenced Files
F2109869: D11688.id39218.diff
Tue, Jun 25, 5:52 PM
Unknown Object (File)
Mon, Jun 24, 7:34 AM
Unknown Object (File)
Tue, Jun 18, 11:40 PM
Unknown Object (File)
Tue, Jun 18, 11:40 PM
Unknown Object (File)
Tue, Jun 18, 11:40 PM
Unknown Object (File)
Tue, Jun 18, 11:39 PM
Unknown Object (File)
Tue, Jun 18, 5:36 AM
Unknown Object (File)
Fri, Jun 14, 4:54 AM
View All 20 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMb1050c45b384: [native] Purge the store after clearing the DB
Summary

clearSensitiveData clears the token, which causes an event to be emitted, which causes AccessTokenHandler to dispatch a new action. This action is dispatched after the store is purged and causes a new state to be persisted. The solution is to purge after the clearing of the DB is finished.

https://linear.app/comm/issue/ENG-7788/state-difference-after-state-wipe

Test Plan

Wipe the state, start the app - there should be no state diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
redux/
4 lines
utils/
2 lines

Diff 39226

View Options

native/redux/persist.js

Loading...
View Options

native/utils/crash-utils.js

Loading...