Page MenuHomePhabricator
Differential D11761

[lib] Extract useRawKeyserverAuth
ClosedPublic
Actions

Authored by ashoat on Apr 24 2024, 12:39 PM.
Tags
None
Referenced Files
F3504357: D11761.id39552.diff
Fri, Dec 20, 8:46 AM
F3504349: D11761.id39447.diff
Fri, Dec 20, 8:43 AM
Unknown Object (File)
Sun, Dec 8, 3:22 AM
Unknown Object (File)
Nov 3 2024, 5:29 AM
Unknown Object (File)
Oct 12 2024, 3:34 PM
Unknown Object (File)
Oct 12 2024, 3:34 PM
Unknown Object (File)
Oct 12 2024, 3:33 PM
Unknown Object (File)
Oct 12 2024, 3:33 PM
View All 39 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMMd8130c105d12: [lib] Extract useRawKeyserverAuth
Summary

This addresses ENG-7668, which is explained more in its parent ENG-7667.

Test Plan

This whole stack was tested with the following steps:

  1. On native, attempting to log in with an ETH account that hasn’t been registered yet
  2. On native, attemping to register with an ETH account that has already been registered
  3. On native, log in with an ETH account that has already been registered
  4. On native, register with an ETH account that hasn’t already been registered
  5. On native, register with a password account
  6. On native, log in with a password account
  7. On web, attempting to log in with an ETH account that hasn’t been registered yet
  8. On web, log in with an ETH account that has already been registered
  9. On web, log in with a password account

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 24 2024, 12:39 PM
ashoat added a child revision: D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.
Harbormaster completed remote builds in B28437: Diff 39447.Apr 24 2024, 12:56 PM
ashoat requested review of this revision.Apr 24 2024, 12:56 PM
inka accepted this revision.Apr 25 2024, 2:22 AM
inka added inline comments.
lib/keyserver-conn/keyserver-auth.js
28 ↗(On Diff #39447)

Once D11758 is landed, we should probably use permissionsAndAuthRelatedRequestTimeout

This revision is now accepted and ready to land.Apr 25 2024, 2:22 AM
ashoat added inline comments.Apr 25 2024, 5:45 AM
lib/keyserver-conn/keyserver-auth.js
28 ↗(On Diff #39447)

I don't think so. This isn't a timeout for the request; rather, it's a delay between retries

Closed by commit rCOMMd8130c105d12: [lib] Extract useRawKeyserverAuth (authored by ashoat). · Explain WhyApr 26 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMd8130c105d12: [lib] Extract useRawKeyserverAuth.

Revision Contents
Changeset List

PathSize
lib/
keyserver-conn/
174 lines
176 lines

Diff 39552

View Options

lib/keyserver-conn/keyserver-auth.js

Loading...
View Options

lib/keyserver-conn/keyserver-connection-handler.js

Loading...