[lib] Specify dontPrefixCreator when shimming UPDATE_RELATIONSHIP
ClosedPublic
Actions

Authored by ashoat on May 3 2024, 1:45 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM63793e812a68: [lib] Specify dontPrefixCreator when shimming UPDATE_RELATIONSHIP

Summary

Without this, the shimmed message appears as "You Your connection on Farcaster is on Comm." dontPrefixCreator fixes the issue for notifs, robotext, and message previews.

Test Plan

Confirm that the "You " prefix is gone in robotext and message previews

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 3 2024, 1:45 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 3 2024, 1:45 PM

ashoat mentioned this in D11707: [keyserver] Send farcaster_mutual UPDATE_RELATIONSHIP message when establishing Farcaster relationship.May 3 2024, 1:46 PM

Harbormaster completed remote builds in B28648: Diff 39773.May 3 2024, 2:01 PM

ashoat requested review of this revision.May 3 2024, 2:01 PM

ginsu accepted this revision.May 3 2024, 2:49 PM

This revision is now accepted and ready to land.May 3 2024, 2:49 PM

Closed by commit rCOMM63793e812a68: [lib] Specify dontPrefixCreator when shimming UPDATE_RELATIONSHIP (authored by ashoat). · Explain WhyMay 3 2024, 6:52 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM63793e812a68: [lib] Specify dontPrefixCreator when shimming UPDATE_RELATIONSHIP.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

1 line

Diff 39773

View Options

lib/shared/messages/update-relationship-message-spec.js

[lib] Specify dontPrefixCreator when shimming UPDATE_RELATIONSHIPClosedPublicActions