[lib] Show other user FID in FARCASTER_MUTUAL robotext
ClosedPublic
Actions

Authored by ashoat on May 3 2024, 7:32 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM84a81b0ad11a: [lib] Show other user FID in FARCASTER_MUTUAL robotext

Summary

To look up their Farcaster username we'll need to integrate Neynar into keyserver/web, but we can display the FID now.

I decided to start with the FID so I could test the general machinery and ended up finding some issues, which are addressed in D11870 and D11871.

Test Plan

creator view	recipient view

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 3 2024, 7:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 3 2024, 7:32 PM

ashoat edited the summary of this revision. (Show Details)May 3 2024, 7:32 PM

ashoat edited the test plan for this revision. (Show Details)May 3 2024, 7:35 PM

Harbormaster completed remote builds in B28652: Diff 39778.May 3 2024, 7:48 PM

ashoat requested review of this revision.May 3 2024, 7:48 PM

ginsu accepted this revision.May 3 2024, 11:35 PM

This revision is now accepted and ready to land.May 3 2024, 11:35 PM

Closed by commit rCOMM84a81b0ad11a: [lib] Show other user FID in FARCASTER_MUTUAL robotext (authored by ashoat). · Explain WhyMay 5 2024, 2:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM84a81b0ad11a: [lib] Show other user FID in FARCASTER_MUTUAL robotext.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

12 lines

Diff 39778

View Options

lib/shared/messages/update-relationship-message-spec.js

[lib] Show other user FID in FARCASTER_MUTUAL robotextClosedPublicActions