Page MenuHomePhabricator
Differential D11911

[lib] hooks for reserved registration
AbandonedPublic
Actions

Authored by varun on May 6 2024, 7:29 AM.
Tags
None
Referenced Files
F3572377: D11911.id39857.diff
Sat, Dec 28, 11:55 AM
F3572354: D11911.id.diff
Sat, Dec 28, 11:55 AM
Unknown Object (File)
Wed, Dec 18, 1:43 AM
Unknown Object (File)
Sat, Nov 30, 1:04 AM
Unknown Object (File)
Nov 28 2024, 7:04 PM
Unknown Object (File)
Nov 28 2024, 11:02 AM
Unknown Object (File)
Nov 22 2024, 11:02 PM
Unknown Object (File)
Nov 14 2024, 12:37 PM
View All 84 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Summary

these aren't really necessary, but in the next diff, i was getting a flow error when i tried using the identity client methods directly

Depends on D11910

Test Plan

tested from js later in stack by calling the useLogIn hooks with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 6 2024, 7:29 AM
varun added a child revision: D11912: [lib] add reserved username workflow to identity login actions.May 6 2024, 7:33 AM
varun added inline comments.May 6 2024, 7:37 AM
lib/actions/user-actions.js
552

i'll separate these hooks from identityRegisterActionTypes a little, because they're not actually intended to be dispatched with those action types

1012–1014

we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks

varun published this revision for review.May 6 2024, 7:48 AM
varun planned changes to this revision.
Harbormaster completed remote builds in B28708: Diff 39857.May 6 2024, 7:57 AM
varun abandoned this revision.May 31 2024, 12:55 PM

we dont need these

Revision Contents
Changeset List

PathSize
lib/
actions/
31 lines

Diff 39857

View Options

lib/actions/user-actions.js

Loading...