[native] add reserved registration methods to IdentityServiceContextProvider
ClosedPublic
Actions

Authored by varun on May 6 2024, 7:26 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM3963159ef6c5: [native] add reserved registration methods to IdentityServiceContextProvider

Summary

we need this so we can call the methods from user-actions.js using the identity client

Depends on D11909

Test Plan

tested from js later in stack by calling the useLogIn hook with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.May 6 2024, 7:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 6 2024, 7:26 AM

varun added a child revision: D11911: [lib] hooks for reserved registration.May 6 2024, 7:29 AM

varun edited the test plan for this revision. (Show Details)May 6 2024, 7:30 AM

Harbormaster completed remote builds in B28707: Diff 39856.May 6 2024, 7:52 AM

varun requested review of this revision.May 6 2024, 7:52 AM

This code is almost entirely a copy-paste from existing endpoints. Can we reduce the duplication?

lib/types/identity-service-types.js
131 ↗	(On Diff #39856)	Why do we change this in an unrelated diff?

This revision is now accepted and ready to land.May 7 2024, 1:47 AM

varun added inline comments.May 7 2024, 2:40 PM

lib/types/identity-service-types.js
131 ↗	(On Diff #39856)	ah, sorry, forgot to annotate this change. noticed while working on this diff that the signatures of `registerPasswordUser` and `registerWalletUser` in `native/identity-service/identity-service-context-provider.react.js` didn't match what we had here. it seems that optional methods' signatures aren't enforced by flow