Page MenuHomePhabricator
Differential D11910

[native] add reserved registration methods to IdentityServiceContextProvider
AcceptedPublic
Actions

Authored by varun on Mon, May 6, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 18, 3:39 AM
Unknown Object (File)
Fri, May 17, 8:06 PM
Unknown Object (File)
Sat, May 11, 11:54 PM
Unknown Object (File)
Sat, May 11, 2:00 PM
Unknown Object (File)
Thu, May 9, 10:20 AM
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

we need this so we can call the methods from user-actions.js using the identity client

Depends on D11909

Test Plan

tested from js later in stack by calling the useLogIn hook with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mon, May 6, 7:26 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMon, May 6, 7:26 AM
varun added a child revision: D11911: [lib] hooks for reserved registration.Mon, May 6, 7:29 AM
varun edited the test plan for this revision. (Show Details)Mon, May 6, 7:30 AM
Harbormaster completed remote builds in B28707: Diff 39856.Mon, May 6, 7:52 AM
varun requested review of this revision.Mon, May 6, 7:52 AM
tomek accepted this revision.Tue, May 7, 1:47 AM

This code is almost entirely a copy-paste from existing endpoints. Can we reduce the duplication?

lib/types/identity-service-types.js
131

Why do we change this in an unrelated diff?

This revision is now accepted and ready to land.Tue, May 7, 1:47 AM
varun added inline comments.Tue, May 7, 2:40 PM
lib/types/identity-service-types.js
131

ah, sorry, forgot to annotate this change. noticed while working on this diff that the signatures of registerPasswordUser and registerWalletUser in native/identity-service/identity-service-context-provider.react.js didn't match what we had here. it seems that optional methods' signatures aren't enforced by flow

bartek added a comment.Fri, May 17, 7:22 AM

When rebasing, you'll have to add initialDeviceListparam - see D12017 and the following diffs in that stack (D12067 is relevant here)

Revision Contents
Changeset List

PathSize
lib/
types/
19 lines
native/
identity-service/
99 lines

Diff 39856

View Options

lib/types/identity-service-types.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...