Page MenuHomePhabricator

[native] add reserved registration methods to IdentityServiceContextProvider
ClosedPublic

Authored by varun on May 6 2024, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 7:07 AM
Unknown Object (File)
Tue, Nov 12, 5:26 AM
Unknown Object (File)
Tue, Nov 12, 3:46 AM
Unknown Object (File)
Mon, Nov 11, 9:57 PM
Unknown Object (File)
Oct 22 2024, 12:50 AM
Unknown Object (File)
Oct 10 2024, 9:17 PM
Unknown Object (File)
Oct 10 2024, 9:17 PM
Unknown Object (File)
Oct 10 2024, 9:17 PM
Subscribers

Details

Summary

we need this so we can call the methods from user-actions.js using the identity client

Depends on D11909

Test Plan

tested from js later in stack by calling the useLogIn hook with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.May 6 2024, 7:52 AM

This code is almost entirely a copy-paste from existing endpoints. Can we reduce the duplication?

lib/types/identity-service-types.js
131

Why do we change this in an unrelated diff?

This revision is now accepted and ready to land.May 7 2024, 1:47 AM
lib/types/identity-service-types.js
131

ah, sorry, forgot to annotate this change. noticed while working on this diff that the signatures of registerPasswordUser and registerWalletUser in native/identity-service/identity-service-context-provider.react.js didn't match what we had here. it seems that optional methods' signatures aren't enforced by flow

When rebasing, you'll have to add initialDeviceListparam - see D12017 and the following diffs in that stack (D12067 is relevant here)