Page MenuHomePhabricator
Differential D11910

[native] add reserved registration methods to IdentityServiceContextProvider
ClosedPublic
Actions

Authored by varun on May 6 2024, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 9:05 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 2 2025, 1:41 PM
Unknown Object (File)
Jan 22 2025, 12:02 AM
Unknown Object (File)
Jan 5 2025, 4:54 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM3963159ef6c5: [native] add reserved registration methods to IdentityServiceContextProvider
Summary

we need this so we can call the methods from user-actions.js using the identity client

Depends on D11909

Test Plan

tested from js later in stack by calling the useLogIn hook with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.May 6 2024, 7:26 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 6 2024, 7:26 AM
varun added a child revision: D11911: [lib] hooks for reserved registration.May 6 2024, 7:29 AM
varun edited the test plan for this revision. (Show Details)May 6 2024, 7:30 AM
Harbormaster completed remote builds in B28707: Diff 39856.May 6 2024, 7:52 AM
varun requested review of this revision.May 6 2024, 7:52 AM
tomek accepted this revision.May 7 2024, 1:47 AM

This code is almost entirely a copy-paste from existing endpoints. Can we reduce the duplication?

lib/types/identity-service-types.js
131 ↗(On Diff #39856)

Why do we change this in an unrelated diff?

This revision is now accepted and ready to land.May 7 2024, 1:47 AM
varun added inline comments.May 7 2024, 2:40 PM
lib/types/identity-service-types.js
131 ↗(On Diff #39856)

ah, sorry, forgot to annotate this change. noticed while working on this diff that the signatures of registerPasswordUser and registerWalletUser in native/identity-service/identity-service-context-provider.react.js didn't match what we had here. it seems that optional methods' signatures aren't enforced by flow

bartek added a comment.May 17 2024, 7:22 AM

When rebasing, you'll have to add initialDeviceListparam - see D12017 and the following diffs in that stack (D12067 is relevant here)

Closed by commit rCOMM3963159ef6c5: [native] add reserved registration methods to IdentityServiceContextProvider (authored by varun). · Explain WhyMay 20 2024, 7:05 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM3963159ef6c5: [native] add reserved registration methods to IdentityServiceContextProvider.

Revision Contents
Changeset List

PathSize
lib/
types/
19 lines
native/
identity-service/
171 lines

Diff 40414

View Options

lib/types/identity-service-types.js

Show All 13 Lines
import androidx.core.app.NotificationCompat; import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle; import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner; import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager; import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils; import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity; import app.comm.android.MainActivity;
import app.comm.android.R; import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat; import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient; import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV; import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities; import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule; import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule; import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils; import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations; import app.comm.android.fbjni.ThreadOperations;
Show All 33 Linespublic class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match // Those and future MMKV-related constants should match
// similar constants in NotificationService.mm // similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = "."; private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER"; private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT"; private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon; private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager; private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager; private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient; private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule; private AESCryptoModuleCompat aesCryptoModule;
public static final String RESCIND_KEY = "rescind"; public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID"; public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title"; public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix"; public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body"; public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos"; public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID"; public static final String THREAD_ID_KEY = "threadID";
public static final String TOKEN_EVENT = "TOKEN_EVENT"; public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT"; public static final String MESSAGE_EVENT = "MESSAGE_EVENT";
@Override @Override
public void onCreate() { public void onCreate() {
super.onCreate(); super.onCreate();
CommSecureStore.getInstance().initialize( CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext())); ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService( notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE); Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this); localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource( displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher); this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient(); servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat(); aesCryptoModule = new AESCryptoModuleCompat();
} }
@Override @Override
public void onNewToken(String token) { public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT); Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token); intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent); localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification"); Log.w("COMM", "Database not existing yet. Skipping notification");
} }
} }
private void handleLargeNotification(RemoteMessage message) { private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY); String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY); String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try { try {
byte[] largePayload = blobClient.getBlobSync(blobHash); byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload); message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message); handleMessageInfosPersistence(message);
} catch (Exception e) { } catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e); Log.w("COMM", "Failure when handling large notification.", e);
} }
blobClient.scheduleDeferredBlobDeletion( servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext()); blobHash, blobHolder, this.getApplicationContext());
} }
private void addToThreadGroupAndDisplay( private void addToThreadGroupAndDisplay(
String notificationID, String notificationID,
NotificationCompat.Builder notificationBuilder, NotificationCompat.Builder notificationBuilder,
String threadID) { String threadID) {
▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines
View Options

native/identity-service/identity-service-context-provider.react.js

Show All 13 Lines
import androidx.core.app.NotificationCompat; import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle; import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner; import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager; import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils; import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity; import app.comm.android.MainActivity;
import app.comm.android.R; import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat; import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient; import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV; import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities; import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule; import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule; import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils; import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations; import app.comm.android.fbjni.ThreadOperations;
Show All 33 Linespublic class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match // Those and future MMKV-related constants should match
// similar constants in NotificationService.mm // similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = "."; private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER"; private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT"; private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon; private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager; private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager; private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient; private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule; private AESCryptoModuleCompat aesCryptoModule;
public static final String RESCIND_KEY = "rescind"; public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID"; public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title"; public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix"; public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body"; public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos"; public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID"; public static final String THREAD_ID_KEY = "threadID";
public static final String TOKEN_EVENT = "TOKEN_EVENT"; public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT"; public static final String MESSAGE_EVENT = "MESSAGE_EVENT";
@Override @Override
public void onCreate() { public void onCreate() {
super.onCreate(); super.onCreate();
CommSecureStore.getInstance().initialize( CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext())); ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService( notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE); Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this); localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource( displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher); this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient(); servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat(); aesCryptoModule = new AESCryptoModuleCompat();
} }
@Override @Override
public void onNewToken(String token) { public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT); Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token); intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent); localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification"); Log.w("COMM", "Database not existing yet. Skipping notification");
} }
} }
private void handleLargeNotification(RemoteMessage message) { private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY); String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY); String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try { try {
byte[] largePayload = blobClient.getBlobSync(blobHash); byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload); message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message); handleMessageInfosPersistence(message);
} catch (Exception e) { } catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e); Log.w("COMM", "Failure when handling large notification.", e);
} }
blobClient.scheduleDeferredBlobDeletion( servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext()); blobHash, blobHolder, this.getApplicationContext());
} }
private void addToThreadGroupAndDisplay( private void addToThreadGroupAndDisplay(
String notificationID, String notificationID,
NotificationCompat.Builder notificationBuilder, NotificationCompat.Builder notificationBuilder,
String threadID) { String threadID) {
▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines