Differential D11976

[keyserver] Roll back D11838
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 10:37 AM.

Tags

None

Referenced Files

	F3525328: D11976.id40031.diff
	Mon, Dec 23, 4:35 PM

	F3523717: D11976.diff
	Mon, Dec 23, 10:03 AM

	Unknown Object (File)
	Sat, Dec 21, 7:02 PM

	Unknown Object (File)
	Sat, Dec 21, 7:02 PM

	Unknown Object (File)
	Sat, Dec 21, 7:02 PM

	Unknown Object (File)
	Sat, Dec 21, 7:02 PM

	Unknown Object (File)
	Nov 12 2024, 9:40 AM

	Unknown Object (File)
	Nov 12 2024, 6:57 AM

View All 58 Files

Subscribers

None

Details

Reviewers

tomek
ginsu
will

Commits

rCOMM8bfd5038096c: [keyserver] Roll back D11838

Summary

This solved ENG-8072 in production. It appears that performance was significantly affected by converting this column's type. We'll need to find another approach here.

Test Plan

I deployed this to production and confirmed that it solved ENG-8072

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/fixmaster

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 9 2024, 10:37 AM

Since I already ran this migration on production, it's fairly important that we land it as-is (certainly before anybody else lands a MariaDB migration 62)

ginsu accepted this revision.May 9 2024, 10:48 AM

This revision is now accepted and ready to land.May 9 2024, 10:48 AM

Harbormaster completed remote builds in B28814: Diff 40028.May 9 2024, 10:54 AM

Closed by commit rCOMM8bfd5038096c: [keyserver] Roll back D11838 (authored by ashoat). · Explain WhyMay 9 2024, 11:04 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8bfd5038096c: [keyserver] Roll back D11838.