Page MenuHomePhabricator

[native] Lift cancelButtonExpansion to ChatThreadList
ClosedPublic

Authored by ashoat on May 24 2024, 7:32 AM.
Tags
None
Referenced Files
F3140795: D12210.id40636.diff
Sun, Nov 3, 5:24 AM
Unknown Object (File)
Fri, Nov 1, 5:37 PM
Unknown Object (File)
Fri, Nov 1, 10:32 AM
Unknown Object (File)
Fri, Oct 25, 11:50 PM
Unknown Object (File)
Wed, Oct 23, 11:38 PM
Unknown Object (File)
Mon, Oct 21, 5:41 AM
Unknown Object (File)
Sun, Oct 20, 9:14 AM
Unknown Object (File)
Fri, Oct 18, 6:23 PM
Subscribers

Details

Summary

ChatThreadList can actually render ChatThreadListSearch in two different places: inside the FlatList, and right above it.

We render it inside the FlatList to start, but when the user focuses the search bar, we "dock" it so that the user can still see it while they scroll through the search results.

If we don't lift cancelButtonExpansion, the dismissal animation doesn't work, because it's initiated on a component that is then unmounted.

By lifting this SharedValue, we allow it to be shared between the two components that are mounted in different places.

Depends on D12166

Test Plan

Confirm that the dismiss animation actually works by overriding it to take 3 seconds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage