Page MenuHomePhabricator

[keyserver] Allow staff to use reserved names for invite links
ClosedPublic

Authored by ashoat on May 29 2024, 1:09 PM.
Tags
None
Referenced Files
F2896993: D12243.id40875.diff
Fri, Oct 4, 9:35 PM
Unknown Object (File)
Thu, Oct 3, 2:07 AM
Unknown Object (File)
Thu, Oct 3, 12:41 AM
Unknown Object (File)
Thu, Sep 26, 5:13 PM
Unknown Object (File)
Tue, Sep 10, 9:13 AM
Unknown Object (File)
Mon, Sep 9, 9:28 AM
Unknown Object (File)
Mon, Sep 9, 8:52 AM
Unknown Object (File)
Mon, Sep 9, 8:52 AM
Subscribers
None

Details

Summary

This addresses the second part of ENG-8263: update the keyserver code to allow staff members to set invite links that are reserved.

Depends on D12242

Test Plan

Tested invite link flow end-to-end on web by creating an invite link named "music" as a keyserver admin, and then opening it in an Incognito tab as another user, and confirming I am able to join. Before modifying lib/facts/staff.json to include the local keyserver admin, it did not work. Afterwards it did

I was surprised that the staging blob service did not reject my invite link creation, given that I was using a reserved string. This calls into question whether any changes on the blob service are necessary. Will document this on ENG-8302.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable